Re: [PATCH 13/13] tpm: st33zp24: Make st33zp24_remove() return void

[Jarkko Sakkinen <jarkko@xxxxxxxxxx>]

On Tue, 2021-10-12 at 19:40 +0200, Uwe Kleine-König wrote:
> On Tue, Oct 12, 2021 at 07:47:22PM +0300, Jarkko Sakkinen wrote:
> > On Mon, 2021-10-11 at 15:27 +0200, Uwe Kleine-König wrote:
> > > Up to now st33zp24_remove() returns zero unconditionally. Make it return
> > > void instead which makes it easier to see in the callers that there is
> > > no error to handle.
> > 
> > So, void is not a return value.
> 
> Hmm, would you be more happy with "Make it return no value"? I think
> this is less understandable than "Make it return void". Do you have a
> constructive suggestion how to formulate.

I think it is semantically more correct to say that it does not return
any value, given that it does not do that :-) You can just state e.g.
"Make st33zp24_remove() a void function.", it is semantically sound and
not really that confusing.

/Jarkko