RE: [PATCH 03/13] hwmon: max31722: Warn about failure to put device in stand-by in .remove()

["Hennerich, Michael" <Michael.Hennerich@xxxxxxxxxx>]

> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Sent: Montag, 11. Oktober 2021 15:28
> To: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>; Hennerich, Michael
> <Michael.Hennerich@xxxxxxxxxx>
> Cc: Mark Brown <broonie@xxxxxxxxxx>; linux-spi@xxxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; linux-input@xxxxxxxxxxxxxxx
> Subject: [PATCH 03/13] hwmon: max31722: Warn about failure to put device in
> stand-by in .remove()
> 
> When an spi driver's remove function returns a non-zero error code nothing
> happens apart from emitting a generic error message. Make this error message
> more device specific and return zero instead.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Acked-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>

> ---
>  drivers/hwmon/max31722.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/max31722.c b/drivers/hwmon/max31722.c index
> 613338cbcb17..4cf4fe6809a3 100644
> --- a/drivers/hwmon/max31722.c
> +++ b/drivers/hwmon/max31722.c
> @@ -103,10 +103,16 @@ static int max31722_probe(struct spi_device *spi)
> static int max31722_remove(struct spi_device *spi)  {
>  	struct max31722_data *data = spi_get_drvdata(spi);
> +	int ret;
> 
>  	hwmon_device_unregister(data->hwmon_dev);
> 
> -	return max31722_set_mode(data, MAX31722_MODE_STANDBY);
> +	ret = max31722_set_mode(data, MAX31722_MODE_STANDBY);
> +	if (ret)
> +		/* There is nothing we can do about this ... */
> +		dev_warn(&spi->dev, "Failed to put device in stand-by
> mode\n");
> +
> +	return 0;
>  }
> 
>  static int __maybe_unused max31722_suspend(struct device *dev)
> --
> 2.30.2