Re: [PATCH 3/6] spi: spi-rpc-if: Check return value of rpcif_sw_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 3/6] spi: spi-rpc-if: Check return value of rpcif_sw_init()
From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Date: Thu, 30 Sep 2021 15:41:56 +0200
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Geert Uytterhoeven <geert+renesas@xxxxxxxxx>, Vignesh Raghavendra <vigneshr@xxxxxx>, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx>, devicetree@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-renesas-soc@xxxxxxxxxxxxxxx, Prabhakar <prabhakar.csengg@xxxxxxxxx>, Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
In-reply-to: <20210928140721.8805-4-prabhakar.mahadev-lad.rj@bp.renesas.com>
Mail-followup-to: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>, Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Geert Uytterhoeven <geert+renesas@xxxxxxxxx>, Vignesh Raghavendra <vigneshr@xxxxxx>, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx>, devicetree@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-renesas-soc@xxxxxxxxxxxxxxx, Prabhakar <prabhakar.csengg@xxxxxxxxx>, Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
References: <20210928140721.8805-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210928140721.8805-4-prabhakar.mahadev-lad.rj@bp.renesas.com>

On Tue, Sep 28, 2021 at 03:07:18PM +0100, Lad Prabhakar wrote:
> rpcif_sw_init() can fail so make sure we check the return value
> of it and on error exit rpcif_spi_probe() callback with error code.
> 
> Fixes: eb8d6d464a27 ("spi: add Renesas RPC-IF driver")
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>

If it fails, we should really bail out.

Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature

References:
- [PATCH 0/6] Add SPI Multi I/O Bus Controller support for RZ/G2L
  - From: Lad Prabhakar
- [PATCH 3/6] spi: spi-rpc-if: Check return value of rpcif_sw_init()
  - From: Lad Prabhakar

Prev by Date: Re: [PATCH 2/6] dt-bindings: memory: renesas,rpc-if: Add optional interrupts property
Next by Date: Re: [PATCH 4/6] mtd: hyperbus: rpc-if: Check return value of rpcif_sw_init()
Previous by thread: [PATCH 3/6] spi: spi-rpc-if: Check return value of rpcif_sw_init()
Next by thread: Re: [PATCH 3/6] spi: spi-rpc-if: Check return value of rpcif_sw_init()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Linux ARM (vger)] [Linux ARM MSM] [Linux Omap] [Linux Arm] [Linux Tegra] [Fedora ARM] [Linux for Samsung SOC] [eCos] [Linux Fastboot] [Gcc Help] [Git] [DCCP] [IETF Announce] [Security] [Linux MIPS] [Yosemite Campsites]