Re: [PATCH 1/2] spi: spi-fsl-dspi: Fix issue with uninitialized dma_slave_config

[Vladimir Oltean <vladimir.oltean@xxxxxxx>]

On Tue, Aug 10, 2021 at 11:17:26AM +0300, Tony Lindgren wrote:
> Depending on the DMA driver being used, the struct dma_slave_config may
> need to be initialized to zero for the unused data.
> 
> For example, we have three DMA drivers using src_port_window_size and
> dst_port_window_size. If these are left uninitialized, it can cause DMA
> failures.
> 
> For spi-fsl-dspi, this is probably not currently an issue but is still
> good to fix though.
> 
> Fixes: 90ba37033cb9 ("spi: spi-fsl-dspi: Add DMA support for Vybrid")
> Cc: Sanchayan Maity <maitysanchayan@xxxxxxxxx>
> Cc: Vladimir Oltean <vladimir.oltean@xxxxxxx>
> Cc: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx>
> Cc: Vinod Koul <vkoul@xxxxxxxxxx>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> ---
>  drivers/spi/spi-fsl-dspi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
> --- a/drivers/spi/spi-fsl-dspi.c
> +++ b/drivers/spi/spi-fsl-dspi.c
> @@ -530,6 +530,7 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr)
>  		goto err_rx_dma_buf;
>  	}
>  
> +	memset(&cfg, 0, sizeof(cfg));
>  	cfg.src_addr = phy_addr + SPI_POPR;
>  	cfg.dst_addr = phy_addr + SPI_PUSHR;
>  	cfg.src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
> -- 
> 2.32.0

Does not bother me in the very slightest.

Acked-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>