Re: [bug report] spi: pxa2xx: Reuse int_stop_and_reset() in couple of places

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Wed, Jul 21, 2021 at 04:32:46AM -0700, Dan Carpenter wrote:
> Hello Andy Shevchenko,
> 
> The patch 3bbdc083262d: "spi: pxa2xx: Reuse int_stop_and_reset() in
> couple of places" from Jul 19, 2021, leads to the following static
> checker warning:
> 
> 	drivers/spi/spi-pxa2xx.c:774 ssp_int()
> 	error: we previously assumed 'drv_data->controller->cur_msg' could be null (see line 773)

>     773 	if (!drv_data->controller->cur_msg) {
> --> 774 		handle_bad_msg(drv_data);
>                         ^^^^^^^^^^^^^^^^^^^^^^^^
> We can't reset with a NULL drv_data->controller->cur_msg.

We can if we handle this inside reset_sccr1() properly.
Thanks for the report and patch on its way!

-- 
With Best Regards,
Andy Shevchenko