[PATCH v4 0/5] bus: Make remove callback return void
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: [PATCH v4 0/5] bus: Make remove callback return void
- From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
- Date: Tue, 13 Jul 2021 21:35:17 +0200
- Cc: kernel@xxxxxxxxxxxxxx, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>, Alexandre Bounine <alex.bou9@xxxxxxxxx>, Alex Dubov <oakad@xxxxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Alison Schofield <alison.schofield@xxxxxxxxx>, Allen Hubbe <allenbh@xxxxxxxxx>, Andreas Noever <andreas.noever@xxxxxxxxx>, Andy Gross <agross@xxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>, Ben Widawsky <ben.widawsky@xxxxxxxxx>, Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Bodo Stroesser <bostroesser@xxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Chen-Yu Tsai <wens@xxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, Cristian Marussi <cristian.marussi@xxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Dave Jiang <dave.jiang@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, David Woodhouse <dwmw@xxxxxxxxxxxx>, Dexuan Cui <decui@xxxxxxxxxxxxx>, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>, Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>, Eric Farman <farman@xxxxxxxxxxxxx>, Finn Thain <fthain@xxxxxxxxxxxxxx>, Florian Fainelli <f.fainelli@xxxxxxxxx>, Frank Li <lznuaa@xxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Geoff Levand <geoff@xxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, Halil Pasic <pasic@xxxxxxxxxxxxx>, Hannes Reinecke <hare@xxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>, Harald Freudenberger <freude@xxxxxxxxxxxxx>, Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Ira Weiny <ira.weiny@xxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Jaroslav Kysela <perex@xxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Jens Taprogge <jens.taprogge@xxxxxxxxxxxx>, Jernej Skrabec <jernej.skrabec@xxxxxxxxx>, Jiri Kosina <jikos@xxxxxxxxxx>, Jiri Slaby <jirislaby@xxxxxxxxxx>, Joey Pabalan <jpabalanb@xxxxxxxxx>, Johan Hovold <johan@xxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Johannes Thumshirn <morbidrsa@xxxxxxxxx>, Jon Mason <jdmason@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>, Kirti Wankhede <kwankhede@xxxxxxxxxx>, Kishon Vijay Abraham I <kishon@xxxxxx>, Krzysztof Wilczyński <kw@xxxxxxxxx>, "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>, Lee Jones <lee.jones@xxxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>, Manohar Vanga <manohar.vanga@xxxxxxxxx>, Marc Zyngier <maz@xxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Mark Gross <mgross@xxxxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Martyn Welch <martyn@xxxxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Matthew Rosato <mjrosato@xxxxxxxxxxxxx>, Matt Porter <mporter@xxxxxxxxxxxxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, Maxime Ripard <mripard@xxxxxxxxxx>, Maximilian Luz <luzmaximilian@xxxxxxxxx>, Maxim Levitsky <maximlevitsky@xxxxxxxxx>, Michael Buesch <m@xxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Michael Jamet <michael.jamet@xxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>, Mike Christie <michael.christie@xxxxxxxxxx>, Moritz Fischer <mdf@xxxxxxxxxx>, Ohad Ben-Cohen <ohad@xxxxxxxxxx>, Pali Rohár <pali@xxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, Peter Oberparleiter <oberpar@xxxxxxxxxxxxx>, "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>, Rafał Miłecki <zajec5@xxxxxxxxx>, Rich Felker <dalias@xxxxxxxx>, Rikard Falkeborn <rikard.falkeborn@xxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, "Russell King (Oracle)" <rmk+kernel@xxxxxxxxxxxxxxx>, Samuel Holland <samuel@xxxxxxxxxxxx>, Samuel Iglesias Gonsalvez <siglesias@xxxxxxxxxx>, SeongJae Park <sjpark@xxxxxxxxx>, Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>, Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxx>, Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>, Sudeep Holla <sudeep.holla@xxxxxxx>, Sven Van Asbroeck <TheSven73@xxxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, Thorsten Scherer <t.scherer@xxxxxxxxxxxx>, Tomas Winkler <tomas.winkler@xxxxxxxxx>, Tom Rix <trix@xxxxxxxxxx>, Tyrel Datwyler <tyreld@xxxxxxxxxxxxx>, Ulf Hansson <ulf.hansson@xxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Vineeth Vijayan <vneethv@xxxxxxxxxxxxx>, Vinod Koul <vkoul@xxxxxxxxxx>, Vishal Verma <vishal.l.verma@xxxxxxxxx>, Wei Liu <wei.liu@xxxxxxxxxx>, William Breathitt Gray <vilhelm.gray@xxxxxxxxx>, Wolfram Sang <wsa@xxxxxxxxxx>, Wu Hao <hao.wu@xxxxxxxxx>, Yehezkel Bernat <YehezkelShB@xxxxxxxxx>, Yoshinori Sato <ysato@xxxxxxxxxxxxx>, YueHaibing <yuehaibing@xxxxxxxxxx>, Yufen Yu <yuyufen@xxxxxxxxxx>, alsa-devel@xxxxxxxxxxxxxxxx, dmaengine@xxxxxxxxxxxxxxx, greybus-dev@xxxxxxxxxxxxxxxx, industrypack-devel@xxxxxxxxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, linux1394-devel@xxxxxxxxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, linux-cxl@xxxxxxxxxxxxxxx, linux-fpga@xxxxxxxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-i3c@xxxxxxxxxxxxxxxxxxx, linux-input@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-ntb@xxxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-remoteproc@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, linux-sh@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-staging@xxxxxxxxxxxxxxx, linux-sunxi@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, nvdimm@xxxxxxxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
Hello,
this is v4 of the final patch set for my effort to make struct
bus_type::remove return void.
The first four patches contain cleanups that make some of these
callbacks (more obviously) always return 0. They are acked by the
respective maintainers. Bjorn Helgaas explicitly asked to include the
pci patch (#1) into this series, so Greg taking this is fine. I assume
the s390 people are fine with Greg taking patches #2 to #4, too, they
didn't explicitly said so though.
The last patch actually changes the prototype and so touches quite some
drivers and has the potential to conflict with future developments, so I
consider it beneficial to put these patches into next soon. I expect
that it will be Greg who takes the complete series, he already confirmed
via irc (for v2) to look into this series.
The only change compared to v3 is in the fourth patch where I modified a
few more drivers to fix build failures. Some of them were found by build
bots (thanks!), some of them I found myself using a regular expression
search. The newly modified files are:
arch/sparc/kernel/vio.c
drivers/nubus/bus.c
drivers/sh/superhyway/superhyway.c
drivers/vlynq/vlynq.c
drivers/zorro/zorro-driver.c
sound/ac97/bus.c
Best regards
Uwe
Uwe Kleine-König (5):
PCI: endpoint: Make struct pci_epf_driver::remove return void
s390/cio: Make struct css_driver::remove return void
s390/ccwgroup: Drop if with an always false condition
s390/scm: Make struct scm_driver::remove return void
bus: Make remove callback return void
arch/arm/common/locomo.c | 3 +--
arch/arm/common/sa1111.c | 4 +---
arch/arm/mach-rpc/ecard.c | 4 +---
arch/mips/sgi-ip22/ip22-gio.c | 3 +--
arch/parisc/kernel/drivers.c | 5 ++---
arch/powerpc/platforms/ps3/system-bus.c | 3 +--
arch/powerpc/platforms/pseries/ibmebus.c | 3 +--
arch/powerpc/platforms/pseries/vio.c | 3 +--
arch/s390/include/asm/eadm.h | 2 +-
arch/sparc/kernel/vio.c | 4 +---
drivers/acpi/bus.c | 3 +--
drivers/amba/bus.c | 4 +---
drivers/base/auxiliary.c | 4 +---
drivers/base/isa.c | 4 +---
drivers/base/platform.c | 4 +---
drivers/bcma/main.c | 6 ++----
drivers/bus/sunxi-rsb.c | 4 +---
drivers/cxl/core.c | 3 +--
drivers/dax/bus.c | 4 +---
drivers/dma/idxd/sysfs.c | 4 +---
drivers/firewire/core-device.c | 4 +---
drivers/firmware/arm_scmi/bus.c | 4 +---
drivers/firmware/google/coreboot_table.c | 4 +---
drivers/fpga/dfl.c | 4 +---
drivers/hid/hid-core.c | 4 +---
drivers/hid/intel-ish-hid/ishtp/bus.c | 4 +---
drivers/hv/vmbus_drv.c | 5 +----
drivers/hwtracing/intel_th/core.c | 4 +---
drivers/i2c/i2c-core-base.c | 5 +----
drivers/i3c/master.c | 4 +---
drivers/input/gameport/gameport.c | 3 +--
drivers/input/serio/serio.c | 3 +--
drivers/ipack/ipack.c | 4 +---
drivers/macintosh/macio_asic.c | 4 +---
drivers/mcb/mcb-core.c | 4 +---
drivers/media/pci/bt8xx/bttv-gpio.c | 3 +--
drivers/memstick/core/memstick.c | 3 +--
drivers/mfd/mcp-core.c | 3 +--
drivers/misc/mei/bus.c | 4 +---
drivers/misc/tifm_core.c | 3 +--
drivers/mmc/core/bus.c | 4 +---
drivers/mmc/core/sdio_bus.c | 4 +---
drivers/net/netdevsim/bus.c | 3 +--
drivers/ntb/core.c | 4 +---
drivers/ntb/ntb_transport.c | 4 +---
drivers/nubus/bus.c | 6 ++----
drivers/nvdimm/bus.c | 3 +--
drivers/pci/endpoint/pci-epf-core.c | 7 ++-----
drivers/pci/pci-driver.c | 3 +--
drivers/pcmcia/ds.c | 4 +---
drivers/platform/surface/aggregator/bus.c | 4 +---
drivers/platform/x86/wmi.c | 4 +---
drivers/pnp/driver.c | 3 +--
drivers/rapidio/rio-driver.c | 4 +---
drivers/rpmsg/rpmsg_core.c | 7 ++-----
drivers/s390/block/scm_drv.c | 4 +---
drivers/s390/cio/ccwgroup.c | 6 +-----
drivers/s390/cio/chsc_sch.c | 3 +--
drivers/s390/cio/css.c | 7 +++----
drivers/s390/cio/css.h | 2 +-
drivers/s390/cio/device.c | 9 +++------
drivers/s390/cio/eadm_sch.c | 4 +---
drivers/s390/cio/scm.c | 5 +++--
drivers/s390/cio/vfio_ccw_drv.c | 3 +--
drivers/s390/crypto/ap_bus.c | 4 +---
drivers/scsi/scsi_debug.c | 3 +--
drivers/sh/superhyway/superhyway.c | 8 ++------
drivers/siox/siox-core.c | 4 +---
drivers/slimbus/core.c | 4 +---
drivers/soc/qcom/apr.c | 4 +---
drivers/spi/spi.c | 4 +---
drivers/spmi/spmi.c | 3 +--
drivers/ssb/main.c | 4 +---
drivers/staging/fieldbus/anybuss/host.c | 4 +---
drivers/staging/greybus/gbphy.c | 4 +---
drivers/target/loopback/tcm_loop.c | 5 ++---
drivers/thunderbolt/domain.c | 4 +---
drivers/tty/serdev/core.c | 4 +---
drivers/usb/common/ulpi.c | 4 +---
drivers/usb/serial/bus.c | 4 +---
drivers/usb/typec/bus.c | 4 +---
drivers/vdpa/vdpa.c | 4 +---
drivers/vfio/mdev/mdev_driver.c | 4 +---
drivers/virtio/virtio.c | 3 +--
drivers/vlynq/vlynq.c | 4 +---
drivers/vme/vme.c | 4 +---
drivers/xen/xenbus/xenbus.h | 2 +-
drivers/xen/xenbus/xenbus_probe.c | 4 +---
drivers/zorro/zorro-driver.c | 3 +--
include/linux/device/bus.h | 2 +-
include/linux/pci-epf.h | 2 +-
sound/ac97/bus.c | 6 ++----
sound/aoa/soundbus/core.c | 4 +---
93 files changed, 107 insertions(+), 263 deletions(-)
base-commit: e73f0f0ee7541171d89f2e2491130c7771ba58d3
--
2.30.2
[Index of Archives]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|