Re: [PATCH v2 4/4] bus: Make remove callback return void
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2 4/4] bus: Make remove callback return void
- From: Thorsten Scherer <t.scherer@xxxxxxxxxxxx>
- Date: Wed, 7 Jul 2021 23:51:54 +0200
- Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, kernel@xxxxxxxxxxxxxx, Cornelia Huck <cohuck@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Russell King <linux@xxxxxxxxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Geoff Levand <geoff@xxxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, William Breathitt Gray <vilhelm.gray@xxxxxxxxx>, Rafał Miłecki <zajec5@xxxxxxxxx>, Maxime Ripard <mripard@xxxxxxxxxx>, Chen-Yu Tsai <wens@xxxxxxxx>, Jernej Skrabec <jernej.skrabec@xxxxxxxxx>, Alison Schofield <alison.schofield@xxxxxxxxx>, Vishal Verma <vishal.l.verma@xxxxxxxxx>, Ira Weiny <ira.weiny@xxxxxxxxx>, Ben Widawsky <ben.widawsky@xxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Dave Jiang <dave.jiang@xxxxxxxxx>, Vinod Koul <vkoul@xxxxxxxxxx>, Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx>, Sudeep Holla <sudeep.holla@xxxxxxx>, Cristian Marussi <cristian.marussi@xxxxxxx>, Wu Hao <hao.wu@xxxxxxxxx>, Tom Rix <trix@xxxxxxxxxx>, Moritz Fischer <mdf@xxxxxxxxxx>, Jiri Kosina <jikos@xxxxxxxxxx>, Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>, Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>, "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>, Wei Liu <wei.liu@xxxxxxxxxx>, Dexuan Cui <decui@xxxxxxxxxxxxx>, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, Wolfram Sang <wsa@xxxxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>, Samuel Iglesias Gonsalvez <siglesias@xxxxxxxxxx>, Jens Taprogge <jens.taprogge@xxxxxxxxxxxx>, Johannes Thumshirn <morbidrsa@xxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, Maxim Levitsky <maximlevitsky@xxxxxxxxx>, Alex Dubov <oakad@xxxxxxxxx>, Ulf Hansson <ulf.hansson@xxxxxxxxxx>, Lee Jones <lee.jones@xxxxxxxxxx>, Tomas Winkler <tomas.winkler@xxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jon Mason <jdmason@xxxxxxxx>, Allen Hubbe <allenbh@xxxxxxxxx>, Kishon Vijay Abraham I <kishon@xxxxxx>, Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>, Krzysztof Wilczyński <kw@xxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>, Maximilian Luz <luzmaximilian@xxxxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>, Mark Gross <mgross@xxxxxxxxxxxxxxx>, Matt Porter <mporter@xxxxxxxxxxxxxxxxxxx>, Alexandre Bounine <alex.bou9@xxxxxxxxx>, Ohad Ben-Cohen <ohad@xxxxxxxxxx>, Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>, Andy Gross <agross@xxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxx>, Michael Buesch <m@xxxxxxx>, Sven Van Asbroeck <TheSven73@xxxxxxxxx>, Johan Hovold <johan@xxxxxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, Andreas Noever <andreas.noever@xxxxxxxxx>, Michael Jamet <michael.jamet@xxxxxxxxx>, Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>, Yehezkel Bernat <YehezkelShB@xxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, Jiri Slaby <jirislaby@xxxxxxxxxx>, Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Kirti Wankhede <kwankhede@xxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Martyn Welch <martyn@xxxxxxxxxxxx>, Manohar Vanga <manohar.vanga@xxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Jaroslav Kysela <perex@xxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, Marc Zyngier <maz@xxxxxxxxxx>, Tyrel Datwyler <tyreld@xxxxxxxxxxxxx>, Vladimir Zapolskiy <vz@xxxxxxxxx>, Samuel Holland <samuel@xxxxxxxxxxxx>, Qinglang Miao <miaoqinglang@xxxxxxxxxx>, Alexey Kardashevskiy <aik@xxxxxxxxx>, Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>, Joey Pabalan <jpabalanb@xxxxxxxxx>, Pali Rohár <pali@xxxxxxxxxx>, Adrian Hunter <adrian.hunter@xxxxxxxxx>, Frank Li <lznuaa@xxxxxxxxx>, Mike Christie <michael.christie@xxxxxxxxxx>, Bodo Stroesser <bostroesser@xxxxxxxxx>, Hannes Reinecke <hare@xxxxxxx>, David Woodhouse <dwmw@xxxxxxxxxxxx>, SeongJae Park <sjpark@xxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, linux-sunxi@xxxxxxxxxxxxxxx, linux-cxl@xxxxxxxxxxxxxxx, nvdimm@xxxxxxxxxxxxxxx, dmaengine@xxxxxxxxxxxxxxx, linux1394-devel@xxxxxxxxxxxxxxxxxxxxx, linux-fpga@xxxxxxxxxxxxxxx, linux-input@xxxxxxxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-i3c@xxxxxxxxxxxxxxxxxxx, industrypack-devel@xxxxxxxxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-ntb@xxxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, linux-remoteproc@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, alsa-devel@xxxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-staging@xxxxxxxxxxxxxxx, greybus-dev@xxxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Russell King <rmk+kernel@xxxxxxxxxxxxxxx>, Johannes Thumshirn <jth@xxxxxxxxxx>
- In-reply-to: <20210706154803.1631813-5-u.kleine-koenig@pengutronix.de>
- References: <20210706154803.1631813-1-u.kleine-koenig@pengutronix.de> <20210706154803.1631813-5-u.kleine-koenig@pengutronix.de>
On Tue, Jul 06, 2021 at 05:48:03PM +0200, Uwe Kleine-König wrote:
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
>
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
>
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
[...]
> drivers/siox/siox-core.c | 4 +---
(For drivers/siox)
Acked-by: Thorsten Scherer <t.scherer@xxxxxxxxxxxx>
Best regards
Thorsten
--
Thorsten Scherer | Eckelmann AG | www.eckelmann.de |
[Index of Archives]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|