Re: [PATCH v2 4/4] bus: Make remove callback return void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

v1 was acked by some more after I stopped looking in my mailbox while
preparing v2:

On Tue, Jul 06, 2021 at 05:48:03PM +0200, Uwe Kleine-König wrote:
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
> 
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
> 
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
> 
> Acked-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx> (For ARM, Amba and related parts)
> Acked-by: Mark Brown <broonie@xxxxxxxxxx>
> Acked-by: Chen-Yu Tsai <wens@xxxxxxxx> (for drivers/bus/sunxi-rsb.c)
> Acked-by: Pali Rohár <pali@xxxxxxxxxx>
> Acked-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> (for drivers/media)
> Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx> (For drivers/platform)
> Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> Acked-By: Vinod Koul <vkoul@xxxxxxxxxx>
> Acked-by: Juergen Gross <jgross@xxxxxxxx> (For Xen)
> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx> (For drivers/mfd)
> Acked-by: Johannes Thumshirn <jth@xxxxxxxxxx> (For drivers/mcb)
> Acked-by: Johan Hovold <johan@xxxxxxxxxx>
> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> (For drivers/slimbus)
> Acked-by: Kirti Wankhede <kwankhede@xxxxxxxxxx> (For drivers/vfio)
> Acked-by: Maximilian Luz <luzmaximilian@xxxxxxxxx>
> Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> (For ulpi and typec)
> Acked-by: Samuel Iglesias Gonsálvez <siglesias@xxxxxxxxxx> (For ipack)
> Reviewed-by: Tom Rix <trix@xxxxxxxxxx> (For fpga)
> Acked-by: Geoff Levand <geoff@xxxxxxxxxxxxx> (For ps3)

Acked-by: Yehezkel Bernat <YehezkelShB@xxxxxxxxx> (For thunderbolt)
Reviewed-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
Acked-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx> (For intel_th)
Acked-by: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx> (For pcmcia)

> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux