Re: [PATCH] bus: Make remove callback return void
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] bus: Make remove callback return void
- From: Maximilian Luz <luzmaximilian@xxxxxxxxx>
- Date: Tue, 6 Jul 2021 13:42:31 +0200
- Cc: linux-kernel@xxxxxxxxxxxxxxx, "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, Maxime Ripard <mripard@xxxxxxxxxx>, Jiri Kosina <jikos@xxxxxxxxxx>, "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>, Wei Liu <wei.liu@xxxxxxxxxx>, Dexuan Cui <decui@xxxxxxxxxxxxx>, Johannes Thumshirn <morbidrsa@xxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Krzysztof Wilczyński <kw@xxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>, Mark Gross <mgross@xxxxxxxxxxxxxxx>, Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>, Andy Gross <agross@xxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxx>, Johan Hovold <johan@xxxxxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, Jiri Slaby <jirislaby@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Pali Rohár <pali@xxxxxxxxxx>, Adrian Hunter <adrian.hunter@xxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx, linux-sunxi@xxxxxxxxxxxxxxx, linux-cxl@xxxxxxxxxxxxxxx, nvdimm@xxxxxxxxxxxxxxx, dmaengine@xxxxxxxxxxxxxxx, linux1394-devel@xxxxxxxxxxxxxxxxxxxxx, linux-fpga@xxxxxxxxxxxxxxx, linux-input@xxxxxxxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-i3c@xxxxxxxxxxxxxxxxxxx, industrypack-devel@xxxxxxxxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-ntb@xxxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, linux-remoteproc@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, alsa-devel@xxxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-staging@xxxxxxxxxxxxxxx, greybus-dev@xxxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- In-reply-to: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de>
- References: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0
On 7/6/21 11:50 AM, Uwe Kleine-König wrote:
The driver core ignores the return value of this callback because there
is only little it can do when a device disappears.
This is the final bit of a long lasting cleanup quest where several
buses were converted to also return void from their remove callback.
Additionally some resource leaks were fixed that were caused by drivers
returning an error code in the expectation that the driver won't go
away.
With struct bus_type::remove returning void it's prevented that newly
implemented buses return an ignored error code and so don't anticipate
wrong expectations for driver authors.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
drivers/platform/surface/aggregator/bus.c | 4 +---
Acked-by: Maximilian Luz <luzmaximilian@xxxxxxxxx>
[Index of Archives]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|