Re: [PATCH] bus: Make remove callback return void
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] bus: Make remove callback return void
- From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
- Date: Tue, 6 Jul 2021 11:56:54 +0100
- Cc: kernel@xxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Russell King <linux@xxxxxxxxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Geoff Levand <geoff@xxxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>, Len Brown <lenb@xxxxxxxxxx>, William Breathitt Gray <vilhelm.gray@xxxxxxxxx>, Rafał Miłecki <zajec5@xxxxxxxxx>, Maxime Ripard <mripard@xxxxxxxxxx>, Chen-Yu Tsai <wens@xxxxxxxx>, Jernej Skrabec <jernej.skrabec@xxxxxxxxx>, Alison Schofield <alison.schofield@xxxxxxxxx>, Vishal Verma <vishal.l.verma@xxxxxxxxx>, Ira Weiny <ira.weiny@xxxxxxxxx>, Ben Widawsky <ben.widawsky@xxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Dave Jiang <dave.jiang@xxxxxxxxx>, Vinod Koul <vkoul@xxxxxxxxxx>, Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx>, Sudeep Holla <sudeep.holla@xxxxxxx>, Cristian Marussi <cristian.marussi@xxxxxxx>, Wu Hao <hao.wu@xxxxxxxxx>, Tom Rix <trix@xxxxxxxxxx>, Moritz Fischer <mdf@xxxxxxxxxx>, Jiri Kosina <jikos@xxxxxxxxxx>, Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>, Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>, "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>, Wei Liu <wei.liu@xxxxxxxxxx>, Dexuan Cui <decui@xxxxxxxxxxxxx>, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, Wolfram Sang <wsa@xxxxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>, Samuel Iglesias Gonsalvez <siglesias@xxxxxxxxxx>, Jens Taprogge <jens.taprogge@xxxxxxxxxxxx>, Johannes Thumshirn <morbidrsa@xxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, Maxim Levitsky <maximlevitsky@xxxxxxxxx>, Alex Dubov <oakad@xxxxxxxxx>, Ulf Hansson <ulf.hansson@xxxxxxxxxx>, Lee Jones <lee.jones@xxxxxxxxxx>, Tomas Winkler <tomas.winkler@xxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jon Mason <jdmason@xxxxxxxx>, Allen Hubbe <allenbh@xxxxxxxxx>, Kishon Vijay Abraham I <kishon@xxxxxx>, Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>, Krzysztof Wilczyński <kw@xxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>, Maximilian Luz <luzmaximilian@xxxxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>, Mark Gross <mgross@xxxxxxxxxxxxxxx>, Matt Porter <mporter@xxxxxxxxxxxxxxxxxxx>, linux-arm-msm@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-staging@xxxxxxxxxxxxxxx, greybus-dev@xxxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- In-reply-to: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de>
- References: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0
On 06/07/2021 10:50, Uwe Kleine-König wrote:
The driver core ignores the return value of this callback because there
is only little it can do when a device disappears.
This is the final bit of a long lasting cleanup quest where several
buses were converted to also return void from their remove callback.
Additionally some resource leaks were fixed that were caused by drivers
returning an error code in the expectation that the driver won't go
away.
With struct bus_type::remove returning void it's prevented that newly
implemented buses return an ignored error code and so don't anticipate
wrong expectations for driver authors.
Signed-off-by: Uwe Kleine-König<u.kleine-koenig@xxxxxxxxxxxxxx>
---
...
drivers/slimbus/core.c | 4 +---
for slimbus changes:
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
[Index of Archives]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|