Re: [PATCH] bus: Make remove callback return void
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] bus: Make remove callback return void
- From: Johannes Thumshirn <Johannes.Thumshirn@xxxxxxx>
- Date: Tue, 6 Jul 2021 10:47:28 +0000
- Accept-language: en-US
- Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, "kernel@xxxxxxxxxxxxxx" <kernel@xxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Helge Deller <deller@xxxxxx>, Geoff Levand <geoff@xxxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, "linux-mips@xxxxxxxxxxxxxxx" <linux-mips@xxxxxxxxxxxxxxx>, "linux-parisc@xxxxxxxxxxxxxxx" <linux-parisc@xxxxxxxxxxxxxxx>, "linuxppc-dev@xxxxxxxxxxxxxxxx" <linuxppc-dev@xxxxxxxxxxxxxxxx>, "linux-acpi@xxxxxxxxxxxxxxx" <linux-acpi@xxxxxxxxxxxxxxx>, "linux-wireless@xxxxxxxxxxxxxxx" <linux-wireless@xxxxxxxxxxxxxxx>, "linux-sunxi@xxxxxxxxxxxxxxx" <linux-sunxi@xxxxxxxxxxxxxxx>, "linux-cxl@xxxxxxxxxxxxxxx" <linux-cxl@xxxxxxxxxxxxxxx>, "nvdimm@xxxxxxxxxxxxxxx" <nvdimm@xxxxxxxxxxxxxxx>, "dmaengine@xxxxxxxxxxxxxxx" <dmaengine@xxxxxxxxxxxxxxx>, "linux1394-devel@xxxxxxxxxxxxxxxxxxxxx" <linux1394-devel@xxxxxxxxxxxxxxxxxxxxx>, "linux-fpga@xxxxxxxxxxxxxxx" <linux-fpga@xxxxxxxxxxxxxxx>, "linux-input@xxxxxxxxxxxxxxx" <linux-input@xxxxxxxxxxxxxxx>, "linux-hyperv@xxxxxxxxxxxxxxx" <linux-hyperv@xxxxxxxxxxxxxxx>, "linux-i2c@xxxxxxxxxxxxxxx" <linux-i2c@xxxxxxxxxxxxxxx>, "linux-i3c@xxxxxxxxxxxxxxxxxxx" <linux-i3c@xxxxxxxxxxxxxxxxxxx>, "industrypack-devel@xxxxxxxxxxxxxxxxxxxxx" <industrypack-devel@xxxxxxxxxxxxxxxxxxxxx>, "linux-media@xxxxxxxxxxxxxxx" <linux-media@xxxxxxxxxxxxxxx>, "linux-mmc@xxxxxxxxxxxxxxx" <linux-mmc@xxxxxxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "linux-ntb@xxxxxxxxxxxxxxxx" <linux-ntb@xxxxxxxxxxxxxxxx>, "linux-pci@xxxxxxxxxxxxxxx" <linux-pci@xxxxxxxxxxxxxxx>, "platform-driver-x86@xxxxxxxxxxxxxxx" <platform-driver-x86@xxxxxxxxxxxxxxx>, "linux-remoteproc@xxxxxxxxxxxxxxx" <linux-remoteproc@xxxxxxxxxxxxxxx>, "linux-scsi@xxxxxxxxxxxxxxx" <linux-scsi@xxxxxxxxxxxxxxx>, "alsa-devel@xxxxxxxxxxxxxxxx" <alsa-devel@xxxxxxxxxxxxxxxx>, "linux-arm-msm@xxxxxxxxxxxxxxx" <linux-arm-msm@xxxxxxxxxxxxxxx>, "linux-spi@xxxxxxxxxxxxxxx" <linux-spi@xxxxxxxxxxxxxxx>, "linux-staging@xxxxxxxxxxxxxxx" <linux-staging@xxxxxxxxxxxxxxx>, "greybus-dev@xxxxxxxxxxxxxxxx" <greybus-dev@xxxxxxxxxxxxxxxx>, "target-devel@xxxxxxxxxxxxxxx" <target-devel@xxxxxxxxxxxxxxx>, "linux-usb@xxxxxxxxxxxxxxx" <linux-usb@xxxxxxxxxxxxxxx>, "linux-serial@xxxxxxxxxxxxxxx" <linux-serial@xxxxxxxxxxxxxxx>, "virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx" <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>, "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Ironport-sdr: icKNRiWxHG7lNdL2j1zG3AM6Rff9NRVHa2U8qq5PN+w3lnrwv88m0NJ+vDnvjBPTnlvQlLSWiY oV40So3615VozUwETZcrWCJ/Cag/SBsZaRNZu0wtfu8G1FzbF4vtPT4aMn2gGoVyzGOc6RbbiX 19qvZ/iopksKzx8CU3FNDuGYacgHlYkfjA5T2x57XQ0pa0KYLrP1gjhgIeShC+Z6g6gsjr/iGV dx6BXlJlasDPN9f96BmY2G47ZRWHnAhVl88LxfDWuGPlVs3ZxcLDBykvVEkgDeRA3Z8Qw8Rdrz sMU=
- References: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> <YOQxRS8HLTYthWNn@dell>
- Wdcipoutbound: EOP-TRUE
On 06/07/2021 12:36, Lee Jones wrote:
> On Tue, 06 Jul 2021, Uwe Kleine-König wrote:
>
>> The driver core ignores the return value of this callback because there
>> is only little it can do when a device disappears.
>>
>> This is the final bit of a long lasting cleanup quest where several
>> buses were converted to also return void from their remove callback.
>> Additionally some resource leaks were fixed that were caused by drivers
>> returning an error code in the expectation that the driver won't go
>> away.
>>
>> With struct bus_type::remove returning void it's prevented that newly
>> implemented buses return an ignored error code and so don't anticipate
>> wrong expectations for driver authors.
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>> ---
>> Hello,
>>
>> this patch depends on "PCI: endpoint: Make struct pci_epf_driver::remove
>> return void" that is not yet applied, see
>> https://lore.kernel.org/r/20210223090757.57604-1-u.kleine-koenig@xxxxxxxxxxxxxx.
>>
>> I tested it using allmodconfig on amd64 and arm, but I wouldn't be
>> surprised if I still missed to convert a driver. So it would be great to
>> get this into next early after the merge window closes.
>>
>> I send this mail to all people that get_maintainer.pl emits for this
>> patch. I wonder how many recipents will refuse this mail because of the
>> long Cc: list :-)
>>
>> Best regards
>> Uwe
>>
>> arch/arm/common/locomo.c | 3 +--
>> arch/arm/common/sa1111.c | 4 +---
>> arch/arm/mach-rpc/ecard.c | 4 +---
>> arch/mips/sgi-ip22/ip22-gio.c | 3 +--
>> arch/parisc/kernel/drivers.c | 5 ++---
>> arch/powerpc/platforms/ps3/system-bus.c | 3 +--
>> arch/powerpc/platforms/pseries/ibmebus.c | 3 +--
>> arch/powerpc/platforms/pseries/vio.c | 3 +--
>> drivers/acpi/bus.c | 3 +--
>> drivers/amba/bus.c | 4 +---
>> drivers/base/auxiliary.c | 4 +---
>> drivers/base/isa.c | 4 +---
>> drivers/base/platform.c | 4 +---
>> drivers/bcma/main.c | 6 ++----
>> drivers/bus/sunxi-rsb.c | 4 +---
>> drivers/cxl/core.c | 3 +--
>> drivers/dax/bus.c | 4 +---
>> drivers/dma/idxd/sysfs.c | 4 +---
>> drivers/firewire/core-device.c | 4 +---
>> drivers/firmware/arm_scmi/bus.c | 4 +---
>> drivers/firmware/google/coreboot_table.c | 4 +---
>> drivers/fpga/dfl.c | 4 +---
>> drivers/hid/hid-core.c | 4 +---
>> drivers/hid/intel-ish-hid/ishtp/bus.c | 4 +---
>> drivers/hv/vmbus_drv.c | 5 +----
>> drivers/hwtracing/intel_th/core.c | 4 +---
>> drivers/i2c/i2c-core-base.c | 5 +----
>> drivers/i3c/master.c | 4 +---
>> drivers/input/gameport/gameport.c | 3 +--
>> drivers/input/serio/serio.c | 3 +--
>> drivers/ipack/ipack.c | 4 +---
>> drivers/macintosh/macio_asic.c | 4 +---
>> drivers/mcb/mcb-core.c | 4 +---
Acked-by: Johannes Thumshirn <jth@xxxxxxxxxx> # for drivers/mcb
[Index of Archives]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|