Hello Stephen, On Wed, Jun 09, 2021 at 10:21:23PM +0200, Uwe Kleine-König wrote: > given that I don't succeed in getting any feedback for my patch set, I'm > trying with a pull request today. It would be really great if this pull > request made it finally in for the next merge window. It seems sending a pull request didn't help either :-\ I'm waiting since October for feedback, several people expressed to like this series and I want to make use of it to simplify a few drivers. I'm quite annoyed that your missing feedback blocks me from further improving stuff. > The changes are not as bad or complex as the diffstat suggests. The > first patch contains all the complexity and only has > 1 file changed, 50 insertions(+), 17 deletions(-) > . The second patch makes use of this and just adds kernel-doc, four > functions that are one-line wrappers around the newly introduced > __devm_clk_get() function in the first patch and dummy implementations > for the !CONFIG_HAVE_CLK case. > > The following changes since commit 6efb943b8616ec53a5e444193dccf1af9ad627b5: > > Linux 5.13-rc1 (2021-05-09 14:17:44 -0700) > > are available in the Git repository at: > > https://git.pengutronix.de/git/ukl/linux tags/devm-clk-get-enabled > > for you to fetch changes up to fec74d434d6f6016b6b2d5ab13aa28a0c657f5fb: > > clk: Provide new devm_clk_helpers for prepared and enabled clocks (2021-05-11 14:20:13 +0200) > > ---------------------------------------------------------------- > New variants of devm_clk_get() for prepared and enabled clocks > > These two patches create a set of new devm helpers that return clocks > already prepared or prepared-and-enabled. The automatic cleanup cares > for unpreparing and disabling+unpreparing respectively. > > This allows to simplify various drivers as was demonstrated with > additional patches sent with the various revisions of this patch set. > See > https://lore.kernel.org/r/20210510174142.986250-1-u.kleine-koenig@xxxxxxxxxxxxxx > for the last submission round. This pull request doesn't contain these > patches though. > > ---------------------------------------------------------------- > Uwe Kleine-König (2): > clk: generalize devm_clk_get() a bit > clk: Provide new devm_clk_helpers for prepared and enabled clocks > > drivers/clk/clk-devres.c | 96 ++++++++++++++++++++++++++++++++++++++++-------- > include/linux/clk.h | 90 ++++++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 169 insertions(+), 17 deletions(-) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature