Re: [PATCH v3 3/8] dt-bindings: spi: spi-rockchip: add description for rv1126

[Johan Jonker <jbx6244@xxxxxxxxx>]

Hi Jon,

Some comments. Have a look if it's useful.

===

In order to get this patch reviewed by rob+dt you must include:
robh+dt@xxxxxxxxxx
devicetree@xxxxxxxxxxxxxxx

Check your review status here:
https://patchwork.ozlabs.org/project/devicetree-bindings/list/

Get the other lists and maintainers with:
./scripts/get_maintainer.pl --noroles --norolestats --nogit-fallback
--nogit <patch1> <patch2>

===

Please try to order patches like:
(1) dt-binding - compatible addition
(2) driver patches
(3) devicetree node patches

The script below gives a warning if the wrong order is used.
./scripts/checkpatch.pl --strict <patch1> <patch2>

===

The [PATCH v3 2/8] has duplicate Signed-off-by's.

Signed-off-by: Jon Lin <jon.lin at rock-chips.com>
Signed-off-by: Jon Lin <jon.lin at rock-chips.com>

What has changed in version 3 ?
Maybe add a cover letter and a change log too?
git format-patch -v4 -8 --cover-letter HEAD
===

The commit message in [PATCH v3 4/8] has to many "applications", so
maybe restyle a bit?

Add compatible string for rv1126 to applications for potential
applications.

Adding "rockchip,rv1126-spi" to rockchip_spi_dt_match[] is strictly not
needed when using "rockchip,rk3066-spi" as fall back string.
Could a maintainer advice?

Maybe this bug of mine should revert too?? Or is it legacy? ;)
spi: rockchip: add compatible string for px30 rk3308 rk3328
https://lore.kernel.org/r/20200309151004.7780-1-jbx6244@xxxxxxxxx

===

Johan

On 6/5/21 11:46 AM, Jon Lin wrote:
> The description below will be used for rv1126.dtsi in the future
> 
> Signed-off-by: Jon Lin <jon.lin@xxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/spi/spi-rockchip.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.yaml b/Documentation/devicetree/bindings/spi/spi-rockchip.yaml
> index 1e6cf29e6388..4ed5b72a8494 100644
> --- a/Documentation/devicetree/bindings/spi/spi-rockchip.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-rockchip.yaml
> @@ -27,6 +27,7 @@ properties:
>        - items:
>            - enum:
>                - rockchip,px30-spi

> +              - rockchip,rv1126-spi

Sort alphabetically.

>                - rockchip,rk3188-spi
>                - rockchip,rk3288-spi
>                - rockchip,rk3308-spi
>