Re: [PATCH] spi: stm32-qspi: Fix W=1 build warning

[Randy Dunlap <rdunlap@xxxxxxxxxxxxx>]

On 6/4/21 12:50 AM, patrice.chotard@xxxxxxxxxxx wrote:
> From: Patrice Chotard <patrice.chotard@xxxxxxxxxxx>
> 
> Fix the following compilation warning using W=1 build:
> arm-linux-gnueabi-ld: drivers/spi/spi-stm32-qspi.o: in function `stm32_qspi_poll_status':
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Patrice Chotard <patrice.chotard@xxxxxxxxxxx>

This is a build error, not a warning. The complete message is:

ld: drivers/spi/spi-stm32-qspi.o: in function `stm32_qspi_poll_status':
spi-stm32-qspi.c:(.text+0x661): undefined reference to `spi_mem_supports_op'


Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested


thanks.

> ---
>  drivers/spi/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index f4481fe48bf0..e71a4c514f7b 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -806,6 +806,7 @@ config SPI_STM32_QSPI
>  	tristate "STMicroelectronics STM32 QUAD SPI controller"
>  	depends on ARCH_STM32 || COMPILE_TEST
>  	depends on OF
> +	depends on SPI_MEM
>  	help
>  	  This enables support for the Quad SPI controller in master mode.
>  	  This driver does not support generic SPI. The implementation only
> 


-- 
~Randy