On Mon, May 10, 2021 at 05:10:22PM +0300, Andy Shevchenko wrote: > + bool value = has_acpi_companion(&spi->dev) ? !enable : activate; Please write normal conditional statements to improve legibility. > if (spi->cs_gpiod) > - /* polarity handled by gpiolib */ > - gpiod_set_value_cansleep(spi->cs_gpiod, activate); > + /* Polarity handled by GPIO library */ > + gpiod_set_value_cansleep(spi->cs_gpiod, value); > else > /* > - * invert the enable line, as active low is > + * Invert the enable line, as active low is > * default for SPI. The change would be clearer with the documentation formatting changes split out from the rest of it.
Attachment:
signature.asc
Description: PGP signature
