Re: [PATCH v6 RESEND 0/6] clk: provide new devm helpers for prepared and enabled clocks

[Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>]

On Mon, 10 May 2021 08:17:18 +0200
Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:

> Hello,
> 
> this is just a resend as I didn't get any feedback in the two weeks
> since the original v6 submission. Would be nice to hear something back,
> I'm trying for more than half a year now to get feedback. :-\

I have a bunch of usecases in IIO, (many with local devm_add_action_or_reset()
doing the same thing.)

+CC Alex who sent out a series add more local handling of this case
today.

Code seems correct and clean to me, but whether the clk maintainers
want to encourage this pattern is down to them (I've had similar discussions
about regulators in the past where we've agreed to disagree on this topic).

Jonathan

> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (6):
>   clk: generalize devm_clk_get() a bit
>   clk: Provide new devm_clk_helpers for prepared and enabled clocks
>   pwm: atmel: Simplify using devm_clk_get_prepared()
>   rtc: at91sam9: Simplify using devm_clk_get_enabled()
>   i2c: imx: Simplify using devm_clk_get_enabled()
>   spi: davinci: Simplify using devm_clk_get_enabled()
> 
>  drivers/clk/clk-devres.c     | 96 ++++++++++++++++++++++++++++++------
>  drivers/i2c/busses/i2c-imx.c | 12 +----
>  drivers/pwm/pwm-atmel.c      | 15 +-----
>  drivers/rtc/rtc-at91sam9.c   | 22 ++-------
>  drivers/spi/spi-davinci.c    | 11 +----
>  include/linux/clk.h          | 87 +++++++++++++++++++++++++++++++-
>  6 files changed, 176 insertions(+), 67 deletions(-)
> 
> 
> base-commit: a38fd8748464831584a19438cbb3082b5a2dab15