On Fri, Apr 23, 2021 at 05:56:30PM +0100, Mark Brown wrote: > On Fri, Apr 23, 2021 at 07:34:28PM +0300, Andy Shevchenko wrote: > > > We have two headers split between include/linux and include/linux/spi. > > Consolidated them under SPI realm, i.e. in the latter folder. > > Why? Isn't the point to maintain an abstraction between the general > purpose use of the SSP IP and its application as a SPI controller? Aren't the General Purpose of the SSP IP is an SPI controller either way? What you are talking about is probably GP SPI vs. private (dedicated) SPI. But okay, I got the idea, I can drop this patch. > I'd > check the cover letter for the series but there doesn't seem to be one. Set of cleanups here and there related to the SPI PXA2xx driver. It's hard to add something else here. -- With Best Regards, Andy Shevchenko