Re: [PATCH] spi: sync up initial chipselect state

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Fri, Apr 16, 2021 at 11:11 PM David Bauer <mail@xxxxxxxxxxxxxxx> wrote:
>
> When initially probing the SPI slave device, the call for disabling an
> SPI device without the SPI_CS_HIGH flag is not applied, as the
> condition for checking whether or not the state to be applied equals the
> one currently set evaluates to true.
>
> This however might not necessarily be the case, as the chipselect might
> be active.
>
> Add a force flag to spi_set_cs which allows to override this
> early exit condition. Set it to false everywhere except when called
> from spi_setup to sync up the initial CS state.

> Fixes commit d40f0b6f2e21 ("spi: Avoid setting the chip select if we don't
> need to")

It should be on one line and no blank lines in the tag block.
Otherwise bots will not see it as a fix.

Mark, I guess you need to amend your scripts to check that.

> Signed-off-by: David Bauer <mail@xxxxxxxxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko