On 09/04/2021 08:17, Yicong Yang wrote:
On 2021/4/8 21:51, Mark Brown wrote:
On Thu, Apr 08, 2021 at 07:31:45PM +0800, Yicong Yang wrote:
The ACPI_PTR() and related IS_ENABLED(CONFIG_ACPI) protection is
redundant, so drop them.
The driver supports building without ACPI so are you sure these are
redundant?
yes. we're not using any acpi function in this driver. What ifdef macro
and ACPI_PTR() protects is struct acpi_device_id, which is defined in
mod_devicetable.h rather than acpi.h. It can be built when ACPI=n.
I asked the exact same thing, so another version with an updated commit
message with this info could be useful. Mark's call, though.
Thanks,
John
some similiar cleanups can be found:
6c328c347ac3 ("platform/x86: i2c-multi-instantiate: Drop redundant ACPI_PTR()")
846afc1dbcbf ("iio: accel: bma220: Drop ACPI_PTR() and accompanying ifdeffery")
[...]
Thanks,
Yicong
.
