Re: [PATCH v2 01/13] gpio: Add Elba SoC gpio driver for spi cs control

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Mon, Mar 29, 2021 at 5:01 AM Brad Larson <brad@xxxxxxxxxxx> wrote:
>
> This GPIO driver is for the Pensando Elba SoC which
> provides control of four chip selects on two SPI busses.

Same comments as per v1.
NAK from me until we get settled in that discussion.

...

> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("Pensando Elba SoC SPI chip-select driver");

It's funny, you told it can't be a module and you add a dead code. Be
somehow consistent, please.


-- 
With Best Regards,
Andy Shevchenko