On Sun, Mar 28, 2021 at 06:59:38PM -0700, Brad Larson wrote: > New drivers should include <linux/gpio/driver.h> instead > of legacy <linux/gpio.h>. > > Signed-off-by: Brad Larson <brad@xxxxxxxxxxx> > --- > drivers/gpio/gpio-elba-spics.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-elba-spics.c b/drivers/gpio/gpio-elba-spics.c > index 351bbaeea033..c0dce5333f35 100644 > --- a/drivers/gpio/gpio-elba-spics.c > +++ b/drivers/gpio/gpio-elba-spics.c > @@ -6,11 +6,10 @@ > */ > > #include <linux/err.h> > -#include <linux/gpio.h> > +#include <linux/gpio/driver.h> > #include <linux/module.h> > #include <linux/io.h> > #include <linux/init.h> > -//#include <linux/of.h> > #include <linux/platform_device.h> > #include <linux/spinlock.h> > #include <linux/types.h> > -- > 2.17.1 > This should be part of patch 1/13, do not add a problem and then fix it up in the same patch series. thanks, greg k-h