Dear Mark, On 2021/3/18 21:28, Mark Brown wrote: > On Thu, Mar 18, 2021 at 05:50:24PM +0800, Jay Fang wrote: > >> Changes in v2: >> - Use a more specific name (Kunpeng SoCs) for this driver. > >> drivers/spi/spi-hisi.c | 505 +++++++++++++++++++++++++++++++++++++++++++++++++ > >> +config SPI_HISI >> + tristate "HiSilicon SPI Controller for Kunpeng SoCs" > > You've changed the display name for the driver but the Kconfig symbol > and filename are still very generic - can you update them as well > please? > Will change. Thanks > Otherwise this looks good. >