Hi Andy, On Fri, Feb 26, 2021 at 07:03:09PM +0200, Andy Shevchenko wrote: > On Tue, Feb 16, 2021 at 01:07:39PM +0200, Andy Shevchenko wrote: > > Introduce module_parport_driver() helper macro to reduce boilerplate > > in the existing and new code. > > Sudip, any comments on this? Sorry for the delay in reply. lgtm. I think there are few more drivers which can also use this new helper. Will you like to do them also? Acked-by: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> -- Regards Sudip