On Fri, 2021-02-12 at 12:31 +0000, Mark Brown wrote: > On Thu, Feb 11, 2021 at 07:08:20PM +0100, Nicolas Saenz Julienne wrote: > > > - if (xfer->tx_buf || xfer->rx_buf) { > > + if ((xfer->tx_buf || xfer->rx_buf) && xfer->len) { > > I think the issue here is more that some users were passing in buffers > with zero length transfers, the above check was already intended to > catch this case but was working on the assumption that if there was > nothing to transfer then no buffer would be provided. Fair enough, maybe it makes sense to move the check into __spi_validate() and propagate an error upwards? Regads, Nicolas
Attachment:
signature.asc
Description: This is a digitally signed message part