[PATCH] mailbox: arm_mhuv2: make remove callback return void
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: [PATCH] mailbox: arm_mhuv2: make remove callback return void
- From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
- Date: Tue, 2 Feb 2021 20:43:08 +0100
- Cc: linux-fbdev@xxxxxxxxxxxxxxx, Cornelia Huck <cohuck@xxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, David Airlie <airlied@xxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, alsa-devel@xxxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, Jaroslav Kysela <perex@xxxxxxxx>, Eric Anholt <eric@xxxxxxxxxxxxxxxxxx>, Uwe Kleine-König <u.kleine-koenig.org@xxxxxxxxxxxxxx>, linux-i2c@xxxxxxxxxxxxxxx, Jiri Slaby <jirislaby@xxxxxxxxxx>, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx, Alexandre Torgue <alexandre.torgue@xxxxxx>, linux-rtc@xxxxxxxxxxxxxxx, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, Krzysztof Kozlowski <krzk@xxxxxxxxxx>, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>, linux-serial@xxxxxxxxxxxxxxx, linux-input@xxxxxxxxxxxxxxx, Ulf Hansson <ulf.hansson@xxxxxxxxxx>, Guenter Roeck <linux@xxxxxxxxxxxx>, Mike Leach <mike.leach@xxxxxxxxxx>, linux-watchdog@xxxxxxxxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>, Alessandro Zummo <a.zummo@xxxxxxxxxxxx>, coresight@xxxxxxxxxxxxxxxx, Vladimir Zapolskiy <vz@xxxxxxxxx>, Eric Auger <eric.auger@xxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Matt Mackall <mpm@xxxxxxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>, linux-mmc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, Vinod Koul <vkoul@xxxxxxxxxx>, linux-crypto@xxxxxxxxxxxxxxx, kernel@xxxxxxxxxxxxxx, Leo Yan <leo.yan@xxxxxxxxxx>, dmaengine@xxxxxxxxxxxxxxx
- In-reply-to: <20210202135350.36nj3dmcoq3t7gcf@pengutronix.de>
- References: <20210126165835.687514-1-u.kleine-koenig@pengutronix.de> <20210202135350.36nj3dmcoq3t7gcf@pengutronix.de>
My build tests failed to catch that amba driver that would have needed
adaption in commit 3fd269e74f2f ("amba: Make the remove callback return
void"). Change the remove function to make the driver build again.
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Fixes: 3fd269e74f2f ("amba: Make the remove callback return void")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
---
Hello,
I guess I missed that driver during rebase as it was only introduced in
the last merge window. Sorry for that.
I'm unsure what is the right thing to do now. Should I redo the pull
request (with this patch squashed into 3fd269e74f2f)? Or do we just
apply this patch on top?
FTR, the test robot report is at https://lore.kernel.org/r/202102030343.D9j1wukx-lkp@xxxxxxxxx
Best regards
Uwe
drivers/mailbox/arm_mhuv2.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mailbox/arm_mhuv2.c b/drivers/mailbox/arm_mhuv2.c
index 67fb10885bb4..6cf1991a5c9c 100644
--- a/drivers/mailbox/arm_mhuv2.c
+++ b/drivers/mailbox/arm_mhuv2.c
@@ -1095,14 +1095,12 @@ static int mhuv2_probe(struct amba_device *adev, const struct amba_id *id)
return ret;
}
-static int mhuv2_remove(struct amba_device *adev)
+static void mhuv2_remove(struct amba_device *adev)
{
struct mhuv2 *mhu = amba_get_drvdata(adev);
if (mhu->frame == SENDER_FRAME)
writel_relaxed(0x0, &mhu->send->access_request);
-
- return 0;
}
static struct amba_id mhuv2_ids[] = {
--
2.29.2
Attachment:
signature.asc
Description: PGP signature
[Index of Archives]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|