Re: [PATCH 7/7] arm64: dts: qcom: sdm845: enable dma for spi

[Doug Anderson <dianders@xxxxxxxxxxxx>]

Hi,

On Mon, Jan 11, 2021 at 7:18 AM Vinod Koul <vkoul@xxxxxxxxxx> wrote:
>
> @@ -2622,6 +2626,13 @@ pinmux {
>                                                "gpio2", "gpio3";
>                                         function = "qup0";
>                                 };
> +
> +                               config {

Convention in Qualcomm device tree files seems to be that the node is
"pinconf", not "config".


> +                                       pins = "gpio0", "gpio1",
> +                                              "gpio2", "gpio3";
> +                                       drive-strength = <6>;
> +                                       bias-disable;
> +                               };

Pin config almost never belongs in the SoC dtsi file.  This should be
in the board .dts file.  What if pulls are needed on some pins?  What
if you need a stronger or weaker drive strength?

-Doug