Re: [PATCH 18/31] drm/lima: remove unneeded devm_devfreq_remove_device()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 18/31] drm/lima: remove unneeded devm_devfreq_remove_device()
- From: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
- Date: Mon, 4 Jan 2021 13:02:46 +0530
- Cc: myungjoo.ham@xxxxxxxxxxx, kyungmin.park@xxxxxxxxxxx, cw00.choi@xxxxxxxxxxx, krzk@xxxxxxxxxx, shawnguo@xxxxxxxxxx, s.hauer@xxxxxxxxxxxxxx, kernel@xxxxxxxxxxxxxx, festevam@xxxxxxxxx, linux-imx@xxxxxxx, digetx@xxxxxxxxx, thierry.reding@xxxxxxxxx, jonathanh@xxxxxxxxxx, yuq825@xxxxxxxxx, airlied@xxxxxxxx, daniel@xxxxxxxx, robdclark@xxxxxxxxx, sean@xxxxxxxxxx, robh@xxxxxxxxxx, tomeu.vizoso@xxxxxxxxxxxxx, steven.price@xxxxxxx, alyssa.rosenzweig@xxxxxxxxxxxxx, stanimir.varbanov@xxxxxxxxxx, agross@xxxxxxxxxx, bjorn.andersson@xxxxxxxxxx, mchehab@xxxxxxxxxx, lukasz.luba@xxxxxxx, adrian.hunter@xxxxxxxxx, ulf.hansson@xxxxxxxxxx, vireshk@xxxxxxxxxx, nm@xxxxxx, sboyd@xxxxxxxxxx, broonie@xxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, jirislaby@xxxxxxxxxx, rjw@xxxxxxxxxxxxx, jcrouse@xxxxxxxxxxxxxx, hoegsberg@xxxxxxxxxx, eric@xxxxxxxxxxxxxxxxxx, tzimmermann@xxxxxxx, marijn.suijten@xxxxxxxxxxxxxx, gustavoars@xxxxxxxxxx, emil.velikov@xxxxxxxxxxxxx, jonathan@xxxxxxxx, akhilpo@xxxxxxxxxxxxxx, smasetty@xxxxxxxxxxxxxx, airlied@xxxxxxxxxx, masneyb@xxxxxxxxxxxxx, kalyan_t@xxxxxxxxxxxxxx, tanmay@xxxxxxxxxxxxxx, ddavenport@xxxxxxxxxxxx, jsanka@xxxxxxxxxxxxxx, rnayak@xxxxxxxxxxxxxx, tongtiangen@xxxxxxxxxx, miaoqinglang@xxxxxxxxxx, khsieh@xxxxxxxxxxxxxx, abhinavk@xxxxxxxxxxxxxx, chandanu@xxxxxxxxxxxxxx, groeck@xxxxxxxxxxxx, varar@xxxxxxxxxxxxxx, mka@xxxxxxxxxxxx, harigovi@xxxxxxxxxxxxxx, rikard.falkeborn@xxxxxxxxx, natechancellor@xxxxxxxxx, georgi.djakov@xxxxxxxxxx, akashast@xxxxxxxxxxxxxx, parashar@xxxxxxxxxxxxxx, dianders@xxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-samsung-soc@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-tegra@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, lima@xxxxxxxxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, freedreno@xxxxxxxxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx
- In-reply-to: <20210101165507.19486-19-tiny.windzz@gmail.com>
- References: <20210101165507.19486-1-tiny.windzz@gmail.com> <20210101165507.19486-19-tiny.windzz@gmail.com>
- User-agent: NeoMutt/20180716-391-311a52
On 01-01-21, 16:54, Yangtao Li wrote:
> There is no need to manually release devm related resources.
>
> Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx>
> ---
> drivers/gpu/drm/lima/lima_devfreq.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_devfreq.c b/drivers/gpu/drm/lima/lima_devfreq.c
> index d5937cf86504..7690c5c69f9f 100644
> --- a/drivers/gpu/drm/lima/lima_devfreq.c
> +++ b/drivers/gpu/drm/lima/lima_devfreq.c
> @@ -94,11 +94,6 @@ void lima_devfreq_fini(struct lima_device *ldev)
> devfreq_cooling_unregister(devfreq->cooling);
> devfreq->cooling = NULL;
> }
> -
> - if (devfreq->devfreq) {
> - devm_devfreq_remove_device(ldev->dev, devfreq->devfreq);
> - devfreq->devfreq = NULL;
> - }
> }
Why is this part of this patchset ?
--
viresh
[Index of Archives]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|