On Tue, Dec 22, 2020 at 12:46:01PM +0000, Kostya Porotchkin wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > > There's no matching disable here so we'll leak the enables every time > > setup() is called - we should unwind the enables after calling > > _setup_transfer(). It may be more sensible to just take a runtime PM > > reference rather than do the raw clock API stuff, one less call and means if > > anything else gets added to runtime PM it'll be handled. > [KP] You mean we should call here to orion_spi_runtime_resume() > instead of clk_prepare_enable() and make this PM function available > regardless the CONFIG_PM option? That's one part of the suggestion, yes - the other part is that you need to have a disable matching the enable here.
Attachment:
signature.asc
Description: PGP signature
