On Sat, Dec 12, 2020 at 11:57:15AM +0100, Boris Brezillon wrote: > Sowjanya Komatineni <skomatineni@xxxxxxxxxx> wrote: > > This patch adds a flag SPI_MASTER_USES_HW_DUMMY_CYCLES for the controllers > > that support transfer of dummy cycles by the hardware directly. > Hm, not sure this is a good idea. I mean, if we expect regular SPI > devices to use this feature, then why not, but if it's just for > spi-mem, I'd recommend implementing a driver-specific exec_op() instead > of using the default one. I *have* seen other high speed devices which had padding bits in the transfer (see regmap's pad_bits feature), I think that corresponds to flash dummy bits but haven't checked that the hardware support lines up. I'm not sure it's ever been seen as something that we particularly needed to speed up with hardware offload though. > If we go for those core changes, we should at least add a > ctrl->max_dummy_cycles field so the core can fallback to regular writes > when the number of dummy cycles in the spi_mem_op exceeds what the > controller can do. That seems sensible if there's a risk of controllers being too limited, which knowing hardware seems likely.
Attachment:
signature.asc
Description: PGP signature
