Re: [PATCH] spi: spi-fsl-dspi: Add GPIO chip select support

[Maksim Kiselev <bigunclemax@xxxxxxxxx>]

Hi Vladimir, thanks for the answer!

I must have missed these. In any case, I would like to add
functionality for using GPIO as CS. Because I have a board which
actually uses this. I'II check your solution and modify my patch.

чт, 3 дек. 2020 г. в 20:50, Vladimir Oltean <olteanv@xxxxxxxxx>:
>
> Hi Maxim,
>
> On Thu, Dec 03, 2020 at 08:12:19PM +0300, Максим Киселёв wrote:
> > From: Maxim Kiselev <bigunclemax@xxxxxxxxx>
> > Date: Thu, 3 Dec 2020 18:56:12 +0300
> > Subject: [PATCH] spi: spi-fsl-dspi: Add GPIO chip select support
> >
> > This patch allows use of GPIO for the chip select.
> > Because dSPI controller can't send transactions without hardware chip
> > selects, so first unused native CS will be set in SPI_PUSHR_CMD_PCS
>
> Are you sure?
>
> From the reference manual:
>
> SPIx_PUSHR bits 10–15 PCS:
> Select which PCS signals are to be asserted for the transfer. Refer to
> the chip-specific SPI information for the number of PCS signals used in
> this chip.
> 0 Negate the PCS[x] signal.
> 1 Assert the PCS[x] signal.
>
> And the definition is:
>
> #define SPI_PUSHR_CMD_PCS(x)            (BIT(x) & GENMASK(5, 0))
>
> Notice the BIT(x).
>
> I expect that you can set the PCS to 0 and no hard chip select will
> assert.