… > +++ b/drivers/spi/spi-fsl-lpspi.c > @@ -841,6 +841,11 @@ static int fsl_lpspi_probe(struct platform_device *pdev) > u32 temp; > bool is_slave; > > + if (!np && !lpspi_platform_info) { > + dev_err(&pdev->dev, "can't get the platform data\n"); > + return -EINVAL; > + } … How do you think about to combine these null pointer checks by the logical operator “or” instead of “and”? Regards, Markus