Hi Doug,
@@ -670,7 +674,13 @@ static int __maybe_unused spi_geni_runtime_resume(struct device *dev)
if (ret)
return ret;
- return geni_se_resources_on(&mas->se);
+ ret = geni_se_resources_on(&mas->se);
+ if (ret)
+ return ret;
+
+ dev_pm_opp_set_rate(mas->dev, mas->cur_sclk_hz);
+
+ return 0;
}
Should we fail to resume if error is returned from 'opp_set_rate'?
'spi_geni_prepare_message' use to fail for any error from
'opp_set_rate' before patch series "Avoid clock setting if not needed".
But now it's possible that 'prepare_message' can return success even
when opp are not at desired state(from previous resume call).
Regards,
Akash
static int __maybe_unused spi_geni_suspend(struct device *dev)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project