Hi Pratyush, > > Subject > > Re: [PATCH v4 1/7] mtd: spi-nor: sfdp: get octal mode maximum speed from BFPT > > On 29/05/20 03:36PM, Mason Yang wrote: > > Get maximum operation speed of device in octal mode from > > BFPT 20th DWORD. > > I don't like the idea of getting the maximum operation speed from BFPT > when the Profile 1.0 table already tells us that. For example, the > 200MHz operation dummy cycles field in the 4th DWORD says that a value > of 0 means the frequency is not supported. So the Profile 1.0 table > already tells us what frequencies the flash can run at in xSPI Profile > 1.0 mode. As JEDEC spec. mentioned that Operation faster than 200MHz is not part of the current xSPI Spec. However, this does not prevent vendors from making devices that operate at higher speed. In addition, current xSPP profile 1.0 table only defined up to 200MHz. > > So IMO we should use the Profile 1.0 table for this instead because > it will be a localized change which is easier to maintain. I also get > the feeling it will be less prone to mis-interpretations. > > > Signed-off-by: Mason Yang <masonccyang@xxxxxxxxxxx> > > --- thanks for your time & comments. Mason CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. ===================================================================== ============================================================================ CONFIDENTIALITY NOTE: This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation. Macronix International Co., Ltd. =====================================================================