On 5/25/20 4:12 PM, Andy Shevchenko wrote:
On Mon, May 25, 2020 at 02:25:03PM +0200, Lukas Wunner wrote:
The PXA2xx SPI driver releases a runtime PM ref in the probe error path
even though it hasn't acquired a ref earlier.
Apparently commit e2b714afee32 ("spi: pxa2xx: Disable runtime PM if
controller registration fails") sought to copy-paste the invocation of
pm_runtime_disable() from pxa2xx_spi_remove(), but erroneously copied
the call to pm_runtime_put_noidle() as well. Drop it.
Looks like correct fix to me.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Yes, I think it was blind copy-paste from pxa2xx_spi_remove() where
pm_runtime_put_noidle() is needed due the pm_runtime_get_sync() call but
not in pxa2xx_spi_probe().
Reviewed-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
