Re: [PATCH] spi: Make spi_delay_exec() warn if called from atomic context

[Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>]

On Fri, May 22, 2020 at 07:04:17PM +0300, Andy Shevchenko wrote:
> On Fri, May 22, 2020 at 07:02:33PM +0300, Andy Shevchenko wrote:
> > On Fri, May 22, 2020 at 04:50:05PM +0100, Mark Brown wrote:
> > > If the delay used is long enough the spi_delay_exec() will use a sleeping
> > > function to implement it. Add a might_sleep() here to help avoid callers
> > > using this from an atomic context and running into problems at runtime on
> > > other systems.
> > 
> > Thanks!
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> 
> We may improve it later, though, to be smarter and spill a warning only when it
> uses non-atomic delays. For now this is good enough.

IMO this wouldn't be better than the current solution. might_sleep() is called
"might" to warn that the called method may get to sleep, not shall, not will. As
I see it it's better to warn about the consequences straight away, but not at the
point when the sleeping method is actually called in the atomic context.

-Sergey

> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>