On 13/05/20 15:37, Mark Brown wrote: > Date: Wed, 13 May 2020 15:37:53 +0100 > From: Mark Brown <broonie@xxxxxxxxxx> > To: Lars Povlsen <lars.povlsen@xxxxxxxxxxxxx> > Cc: SoC Team <soc@xxxxxxxxxx>, Microchip Linux Driver Support > <UNGLinuxDriver@xxxxxxxxxxxxx>, linux-spi@xxxxxxxxxxxxxxx, > devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Alexandre Belloni > <alexandre.belloni@xxxxxxxxxxx> > Subject: Re: [PATCH 01/10] spi: dw: Add support for polled operation via no > IRQ specified in DT > User-Agent: Mutt/1.10.1 (2018-07-13) > > On Wed, May 13, 2020 at 04:00:22PM +0200, Lars Povlsen wrote: > > > +#define VALID_IRQ(i) (i >= 0) > > + > > This isn't something that should be defined by an individual driver, it > should be in a generic header. Thanks, I will work with Serge on getting this integrated right. ---Lars