On 05/02/2020 12:19 AM, Rob Herring wrote: >> Renesas Reduced Pin Count Interface (RPC-IF) allows a SPI flash or >> HyperFlash connected to the SoC to be accessed via the external address >> space read mode or the manual mode. >> >> Document the device tree bindings for the Renesas RPC-IF found in the R-Car >> gen3 SoCs. >> >> Based on the original patch by Mason Yang <masonccyang@xxxxxxxxxxx>. >> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> >> >> --- >> Changes in version 2: >> - rewrote the bindings in YAML. >> >> Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml | 88 ++++++++++ >> 1 file changed, 88 insertions(+) >> > > My bot found errors running 'make dt_binding_check' on your patch: > > Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml: while scanning a simple key > in "<unicode string>", line 29, column 9 > could not find expected ':' > in "<unicode string>", line 30, column 1 > Documentation/devicetree/bindings/Makefile:11: recipe for target 'Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.example.dts' failed > make[1]: *** [Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.example.dts] Error 1 > make[1]: *** Waiting for unfinished jobs.... > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml: ignoring, error parsing file > warning: no schema found in file: Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml: ignoring, error parsing file > warning: no schema found in file: Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml > Makefile:1300: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > > See https://patchwork.ozlabs.org/patch/1280942 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > Please check and re-submit. As I've said on IRC, I have troubles installing from dt-schema.git: [headless@wasted renesas-devel]$ pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Collecting git+https://github.com/devicetree-org/dt-schema.git@master Cloning https://github.com/devicetree-org/dt-schema.git (to master) to /tmp/pip-4f91j8zd-build Collecting ruamel.yaml>0.15.69 (from dtschema==2020.6.dev4+g6a941d4) Using cached https://files.pythonhosted.org/packages/a6/92/59af3e38227b9cc14520bf1e59516d99ceca53e3b8448094248171e9432b/ruamel.yaml-0.16.10-py2.py3-none-any.whl Collecting jsonschema>=3.0.1 (from dtschema==2020.6.dev4+g6a941d4) Using cached https://files.pythonhosted.org/packages/c5/8f/51e89ce52a085483359217bc72cdbf6e75ee595d5b1d4b5ade40c7e018b8/jsonschema-3.2.0-py2.py3-none-any.whl Collecting rfc3987 (from dtschema==2020.6.dev4+g6a941d4) Using cached https://files.pythonhosted.org/packages/65/d4/f7407c3d15d5ac779c3dd34fbbc6ea2090f77bd7dd12f207ccf881551208/rfc3987-1.3.8-py2.py3-none-any.whl Collecting ruamel.yaml.clib>=0.1.2 (from ruamel.yaml>0.15.69->dtschema==2020.6.dev4+g6a941d4) Using cached https://files.pythonhosted.org/packages/92/28/612085de3fae9f82d62d80255d9f4cf05b1b341db1e180adcf28c1bf748d/ruamel.yaml.clib-0.2.0.tar.gz No files/directories in /tmp/pip-build-fwtgubpx/ruamel.yaml.clib/pip-egg-info (from PKG-INFO) You are using pip version 8.0.2, however version 20.1 is available. You should consider upgrading via the 'pip install --upgrade pip' command. MBR, Sergei