devm_platform_ioremap_resource() will issue a message in the error case. Thus, no need to duplicate in the driver. Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> --- drivers/spi/spi-dw-mmio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c index bef76e210e091b..d8487209beb818 100644 --- a/drivers/spi/spi-dw-mmio.c +++ b/drivers/spi/spi-dw-mmio.c @@ -148,10 +148,8 @@ static int dw_spi_mmio_probe(struct platform_device *pdev) /* Get basic io resource and map it */ dws->regs = devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(dws->regs)) { - dev_err(&pdev->dev, "SPI region map failed\n"); + if (IS_ERR(dws->regs)) return PTR_ERR(dws->regs); - } dws->irq = platform_get_irq(pdev, 0); if (dws->irq < 0) -- 2.26.2