Hi Mason, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on spi/for-next] [also build test WARNING on linus/master v5.7-rc2 next-20200424] [cannot apply to linux/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Mason-Yang/mtd-spi-nor-Add-support-for-Octal-8D-8D-8D-mode/20200423-041224 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next config: x86_64-randconfig-a003-20200424 (attached as .config) compiler: gcc-6 (Debian 6.3.0-18+deb9u1) 6.3.0 20170516 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/spi/spi-mxic.c: In function 'mxic_spi_mem_prep_op_cfg': >> drivers/spi/spi-mxic.c:302:21: warning: comparison of constant '256ul' with boolean expression is always false [-Wbool-compare] if (op->data.dtr == OP_DATA_DDR) ^~ vim +/256ul +302 drivers/spi/spi-mxic.c 282 283 static u32 mxic_spi_mem_prep_op_cfg(const struct spi_mem_op *op) 284 { 285 u32 cfg = OP_CMD_BYTES(op->cmd.nbytes) | 286 OP_CMD_BUSW(fls(op->cmd.buswidth) - 1) | 287 (op->cmd.dtr ? OP_CMD_DDR : 0); 288 289 if (op->addr.nbytes) 290 cfg |= OP_ADDR_BYTES(op->addr.nbytes) | 291 OP_ADDR_BUSW(fls(op->addr.buswidth) - 1) | 292 (op->addr.dtr ? OP_ADDR_DDR : 0); 293 294 if (op->dummy.nbytes) 295 cfg |= OP_DUMMY_CYC(op->dummy.nbytes); 296 297 if (op->data.nbytes) { 298 cfg |= OP_DATA_BUSW(fls(op->data.buswidth) - 1) | 299 (op->data.dtr ? OP_DATA_DDR : 0); 300 if (op->data.dir == SPI_MEM_DATA_IN) { 301 cfg |= OP_READ; > 302 if (op->data.dtr == OP_DATA_DDR) 303 cfg |= OP_DQS_EN; 304 } 305 } 306 307 return cfg; 308 } 309 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
