Hi Bjorn, Evan,
Given that these two functions only switch the bandwidth request between
some value and 0, I really think we should carry a "bool enabled" on the
path and replace these two functions with
icc_bulk_enable()/icc_bulk_disable().
So, if above is implementation "bool enabled" on path can be used
directly in aggregation of ICC votes on particular node without using
icc_set_bw call, if yes then I am not aware how? or we'll be using
icc_set_bw API indirectly inside icc_bulk APIs?
The added benefit of this would be that you call icc_set_bw() instead of
changing the geni_icc_path->{avg_bw,peak_bw} and don't need to keep
track of them here.
Ok IIUC, we need to call icc_set_bw() from GENI driver only if we change
(avg_bw | peak_bw)?
Regards,
Akash
Yes yes! I had the same thought here [1].
Georgi, what do you think?
-Evan
[1] https://lore.kernel.org/linux-arm-msm/CAE=gft58QsgTCUHMHKJhcM9ZxAeMiY16CrbNv2HaTCRqwtmt7A@xxxxxxxxxxxxxx/
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
