Re: [PATCH v1 22/36] dt-bindings: display: convert samsung,ld9040 to DT Schema

[Rob Herring <robh@xxxxxxxxxx>]

On Sun, Mar 15, 2020 at 02:44:02PM +0100, Sam Ravnborg wrote:
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> ---
>  .../bindings/display/panel/samsung,ld9040.txt |  66 ------------
>  .../display/panel/samsung,ld9040.yaml         | 100 ++++++++++++++++++
>  2 files changed, 100 insertions(+), 66 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/display/panel/samsung,ld9040.txt
>  create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,ld9040.txt b/Documentation/devicetree/bindings/display/panel/samsung,ld9040.txt
> deleted file mode 100644
> index 354d4d1df4ff..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/samsung,ld9040.txt
> +++ /dev/null
> @@ -1,66 +0,0 @@
> -Samsung LD9040 AMOLED LCD parallel RGB panel with SPI control bus
> -
> -Required properties:
> -  - compatible: "samsung,ld9040"
> -  - reg: address of the panel on SPI bus
> -  - vdd3-supply: core voltage supply
> -  - vci-supply: voltage supply for analog circuits
> -  - reset-gpios: a GPIO spec for the reset pin
> -  - display-timings: timings for the connected panel according to [1]
> -
> -The panel must obey rules for SPI slave device specified in document [2].
> -
> -Optional properties:
> -  - power-on-delay: delay after turning regulators on [ms]
> -  - reset-delay: delay after reset sequence [ms]
> -  - panel-width-mm: physical panel width [mm]
> -  - panel-height-mm: physical panel height [mm]
> -
> -The device node can contain one 'port' child node with one child
> -'endpoint' node, according to the bindings defined in [3]. This
> -node should describe panel's video bus.
> -
> -[1]: Documentation/devicetree/bindings/display/panel/display-timing.txt
> -[2]: Documentation/devicetree/bindings/spi/spi-bus.txt
> -[3]: Documentation/devicetree/bindings/media/video-interfaces.txt
> -
> -Example:
> -
> -	lcd@0 {
> -		compatible = "samsung,ld9040";
> -		reg = <0>;
> -		vdd3-supply = <&ldo7_reg>;
> -		vci-supply = <&ldo17_reg>;
> -		reset-gpios = <&gpy4 5 0>;
> -		spi-max-frequency = <1200000>;
> -		spi-cpol;
> -		spi-cpha;
> -		power-on-delay = <10>;
> -		reset-delay = <10>;
> -		panel-width-mm = <90>;
> -		panel-height-mm = <154>;
> -
> -		display-timings {
> -			timing {
> -				clock-frequency = <23492370>;
> -				hactive = <480>;
> -				vactive = <800>;
> -				hback-porch = <16>;
> -				hfront-porch = <16>;
> -				vback-porch = <2>;
> -				vfront-porch = <28>;
> -				hsync-len = <2>;
> -				vsync-len = <1>;
> -				hsync-active = <0>;
> -				vsync-active = <0>;
> -				de-active = <0>;
> -				pixelclk-active = <0>;
> -			};
> -		};
> -
> -		port {
> -			lcd_ep: endpoint {
> -				remote-endpoint = <&fimd_dpi_ep>;
> -			};
> -		};
> -	};
> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml b/Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml
> new file mode 100644
> index 000000000000..b6e7e87411e8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml
> @@ -0,0 +1,100 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/samsung,ld9040.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung LD9040 AMOLED LCD parallel RGB panel with SPI control bus
> +
> +maintainers:
> +  - Andrzej Hajda <a.hajda@xxxxxxxxxxx>
> +
> +allOf:
> +  - $ref: ../../spi/spi-slave.yaml#
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: samsung,ld9040
> +
> +  display-timings: true
> +  port: true
> +  reg: true
> +  reset-gpios: true
> +
> +  vdd3-supply:
> +    description: core voltage supply
> +
> +  vci-supply:
> +    description: voltage supply for analog circuits
> +
> +  power-on-delay:
> +    description: delay after turning regulators on [ms]

This shouldn't really be needed with a specific compatible...

It needs a type reference.

> +
> +  reset-delay:
> +    description: delay after reset sequence [ms]

So does this.

> +
> +  panel-width-mm:
> +    description: physical panel width [mm]

And this.

> +
> +  panel-height-mm:
> +    description: physical panel height [mm]
> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd3-supply
> +  - vci-supply
> +  - reset-gpios
> +  - display-timings
> +
> +examples:
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        lcd@0 {
> +            compatible = "samsung,ld9040";
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            reg = <0>;
> +            vdd3-supply = <&ldo7_reg>;
> +            vci-supply = <&ldo17_reg>;
> +            reset-gpios = <&gpy4 5 0>;
> +            spi-max-frequency = <1200000>;
> +            spi-cpol;
> +            spi-cpha;
> +            power-on-delay = <10>;
> +            reset-delay = <10>;
> +            panel-width-mm = <90>;
> +            panel-height-mm = <154>;
> +
> +            display-timings {
> +                timing {
> +                    clock-frequency = <23492370>;
> +                    hactive = <480>;
> +                    vactive = <800>;
> +                    hback-porch = <16>;
> +                    hfront-porch = <16>;
> +                    vback-porch = <2>;
> +                    vfront-porch = <28>;
> +                    hsync-len = <2>;
> +                    vsync-len = <1>;
> +                    hsync-active = <0>;
> +                    vsync-active = <0>;
> +                    de-active = <0>;
> +                    pixelclk-active = <0>;
> +                };
> +            };
> +
> +            port {
> +                lcd_ep: endpoint {
> +                    remote-endpoint = <&fimd_dpi_ep>;
> +                };
> +            };
> +        };
> +    };
> +
> +...
> -- 
> 2.20.1
>