Re: [PATCH v1 04/36] dt-bindings: display: convert arm,versatile-tft-panel to DT Schema

[Rob Herring <robh@xxxxxxxxxx>]

On Sun, Mar 15, 2020 at 02:43:44PM +0100, Sam Ravnborg wrote:
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> ---
>  .../display/panel/arm,versatile-tft-panel.txt | 31 -----------
>  .../panel/arm,versatile-tft-panel.yaml        | 51 +++++++++++++++++++
>  2 files changed, 51 insertions(+), 31 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/display/panel/arm,versatile-tft-panel.txt
>  create mode 100644 Documentation/devicetree/bindings/display/panel/arm,versatile-tft-panel.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/arm,versatile-tft-panel.txt b/Documentation/devicetree/bindings/display/panel/arm,versatile-tft-panel.txt
> deleted file mode 100644
> index 0601a9e34703..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/arm,versatile-tft-panel.txt
> +++ /dev/null
> @@ -1,31 +0,0 @@
> -ARM Versatile TFT Panels
> -
> -These panels are connected to the daughterboards found on the
> -ARM Versatile reference designs.
> -
> -This device node must appear as a child to a "syscon"-compatible
> -node.
> -
> -Required properties:
> -- compatible: should be "arm,versatile-tft-panel"
> -
> -Required subnodes:
> -- port: see display/panel/panel-common.yaml, graph.txt
> -
> -
> -Example:
> -
> -sysreg@0 {
> -	compatible = "arm,versatile-sysreg", "syscon", "simple-mfd";
> -	reg = <0x00000 0x1000>;
> -
> -	panel: display@0 {
> -		compatible = "arm,versatile-tft-panel";
> -
> -		port {
> -			panel_in: endpoint {
> -				remote-endpoint = <&foo>;
> -			};
> -		};
> -	};
> -};
> diff --git a/Documentation/devicetree/bindings/display/panel/arm,versatile-tft-panel.yaml b/Documentation/devicetree/bindings/display/panel/arm,versatile-tft-panel.yaml
> new file mode 100644
> index 000000000000..8ad7305887b4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/arm,versatile-tft-panel.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/arm,versatile-tft-panel.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ARM Versatile TFT Panels
> +
> +maintainers:
> +  - Linus Walleij <linus.walleij@xxxxxxxxxx>
> +
> +description: |
> +  These panels are connected to the daughterboards found on the
> +  ARM Versatile reference designs.
> +
> +  This device node must appear as a child to a "syscon"-compatible
> +  node.
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: arm,versatile-tft-panel
> +
> +  port: true
> +
> +required:
> +  - compatible
> +  - port
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    sysreg {
> +        compatible = "arm,versatile-sysreg", "syscon", "simple-mfd";
> +        reg = <0x00000 0x1000>;
> +
> +        panel: display@0 {

Drop the unit-address or add 'reg'.

> +            compatible = "arm,versatile-tft-panel";
> +
> +            port {
> +                panel_in: endpoint {
> +                    remote-endpoint = <&foo>;
> +                };
> +            };
> +        };
> +    };
> +
> +...
> -- 
> 2.20.1
>