Re: [PATCH v1 12/36] dt-bindings: display: convert jdi,lt070me05000 to DT Schema

[Vinay Simha B N <simhavcs@xxxxxxxxx>]

sam,

Reviewed-by: Vinay Simha BN <simhavcs@xxxxxxxxx>

Thanks.

On Sun, Mar 15, 2020 at 7:14 PM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
>
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Vinay Simha BN <simhavcs@xxxxxxxxx>
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> ---
>  .../display/panel/jdi,lt070me05000.txt        | 31 ---------
>  .../display/panel/jdi,lt070me05000.yaml       | 69 +++++++++++++++++++
>  2 files changed, 69 insertions(+), 31 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.txt
>  create mode 100644 Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.txt b/Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.txt
> deleted file mode 100644
> index 4989c91d505f..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.txt
> +++ /dev/null
> @@ -1,31 +0,0 @@
> -JDI model LT070ME05000 1200x1920 7" DSI Panel
> -
> -Required properties:
> -- compatible: should be "jdi,lt070me05000"
> -- vddp-supply: phandle of the regulator that provides the supply voltage
> -  Power IC supply (3-5V)
> -- iovcc-supply: phandle of the regulator that provides the supply voltage
> -  IOVCC , power supply for LCM (1.8V)
> -- enable-gpios: phandle of gpio for enable line
> -  LED_EN, LED backlight enable, High active
> -- reset-gpios: phandle of gpio for reset line
> -  This should be 8mA, gpio can be configured using mux, pinctrl, pinctrl-names
> -  XRES, Reset, Low active
> -- dcdc-en-gpios: phandle of the gpio for power ic line
> -  Power IC supply enable, High active
> -
> -Example:
> -
> -       dsi0: qcom,mdss_dsi@4700000 {
> -               panel@0 {
> -                       compatible = "jdi,lt070me05000";
> -                       reg = <0>;
> -
> -                       vddp-supply = <&pm8921_l17>;
> -                       iovcc-supply = <&pm8921_lvs7>;
> -
> -                       enable-gpios = <&pm8921_gpio 36 GPIO_ACTIVE_HIGH>;
> -                       reset-gpios = <&tlmm_pinmux 54 GPIO_ACTIVE_LOW>;
> -                       dcdc-en-gpios = <&pm8921_gpio 23 GPIO_ACTIVE_HIGH>;
> -               };
> -       };
> diff --git a/Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.yaml b/Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.yaml
> new file mode 100644
> index 000000000000..e0abf68ecb19
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/jdi,lt070me05000.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/jdi,lt070me05000.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: JDI model LT070ME05000 1200x1920 7" DSI Panel
> +
> +maintainers:
> +  - Vinay Simha BN <simhavcs@xxxxxxxxx>
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: jdi,lt070me05000
> +
> +  enable-gpios: true
> +  reg: true
> +  reset-gpios: true
> +
> +  vddp-supply:
> +    description: |
> +      The regulator that provides the supply voltage Power IC supply (3-5V)
> +
> +  iovcc-supply:
> +    description: |
> +      The regulator that provides the supply voltage IOVCC,
> +      power supply for LCM (1.8V)
> +
> +  dcdc-en-gpios:
> +    description: |
> +      phandle of the gpio for power ic line
> +      Power IC supply enable, High active
> +
> +required:
> +  - compatible
> +  - reg
> +  - vddp-supply
> +  - iovcc-supply
> +  - enable-gpios
> +  - reset-gpios
> +  - dcdc-en-gpios
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    dsi: qcom,mdss_dsi@4700000 {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@0 {
> +            compatible = "jdi,lt070me05000";
> +            reg = <0>;
> +
> +            vddp-supply = <&pm8921_l17>;
> +            iovcc-supply = <&pm8921_lvs7>;
> +
> +            enable-gpios = <&pm8921_gpio 36 GPIO_ACTIVE_HIGH>;
> +            reset-gpios = <&tlmm_pinmux 54 GPIO_ACTIVE_LOW>;
> +            dcdc-en-gpios = <&pm8921_gpio 23 GPIO_ACTIVE_HIGH>;
> +        };
> +    };
> +
> +...
> --
> 2.20.1
>


-- 
regards,
vinaysimha