Re: [PATCH v1 06/36] dt-bindings: display: convert ilitek,ili9322 to DT Schema
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v1 06/36] dt-bindings: display: convert ilitek,ili9322 to DT Schema
- From: Sam Ravnborg <sam@xxxxxxxxxxxx>
- Date: Sun, 15 Mar 2020 20:24:52 +0100
- Cc: "open list:DRM PANEL DRIVERS" <dri-devel@xxxxxxxxxxxxxxxxxxxxx>, Thierry Reding <thierry.reding@xxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@xxxxxxxxxxxxxxx>, Alexandre Courbot <acourbot@xxxxxxxxxx>, Andrzej Hajda <a.hajda@xxxxxxxxxxx>, Brian Masney <masneyb@xxxxxxxxxxxxx>, Chris Zhong <zyw@xxxxxxxxxxxxxx>, Douglas Anderson <dianders@xxxxxxxxxxxx>, Guido Gunther <agx@xxxxxxxxxxx>, Heiko Schocher <hs@xxxxxxx>, Nikolaus Schaller <hns@xxxxxxxxxxxxx>, Hoegeun Kwon <hoegeun.kwon@xxxxxxxxxxx>, Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>, Jerry Han <hanxu5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>, Jonathan Bakker <xc-racer2@xxxxxxx>, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>, Lin Huang <hl@xxxxxxxxxxxxxx>, linux-spi <linux-spi@xxxxxxxxxxxxxxx>, Marco Franchi <marco.franchi@xxxxxxx>, Marek Belisko <marek@xxxxxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Maxime Ripard <maxime.ripard@xxxxxxxxxxx>, Maxime Ripard <mripard@xxxxxxxxxx>, Nickey Yang <nickey.yang@xxxxxxxxxxxxxx>, Paul Cercueil <paul@xxxxxxxxxxxxxxx>, Peter Rosin <peda@xxxxxxxxxx>, Peter Ujfalusi <peter.ujfalusi@xxxxxx>, Purism Kernel Team <kernel@xxxxxxx>, Robert Chiras <robert.chiras@xxxxxxx>, Sandeep Panda <spanda@xxxxxxxxxxxxxx>, Stefan Mavrodiev <stefan@xxxxxxxxxx>, Tomi Valkeinen <tomi.valkeinen@xxxxxx>, Tony Lindgren <tony@xxxxxxxxxxx>, Vinay Simha BN <simhavcs@xxxxxxxxx>, Werner Johansson <werner.johansson@xxxxxxxxxxxxxx>
- In-reply-to: <CACRpkdYVrTBKxuHSGpd9=03oD4=JVxzJf8fOcQ8uu5eRt9PgAg@mail.gmail.com>
- References: <20200315134416.16527-1-sam@ravnborg.org> <20200315134416.16527-7-sam@ravnborg.org> <CACRpkdYVrTBKxuHSGpd9=03oD4=JVxzJf8fOcQ8uu5eRt9PgAg@mail.gmail.com>
- User-agent: Mutt/1.10.1 (2018-07-13)
Hi Linus.
On Sun, Mar 15, 2020 at 07:54:38PM +0100, Linus Walleij wrote:
> On Sun, Mar 15, 2020 at 2:44 PM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
>
> > The .txt binding explains:
> >
> > "
> > The following optional properties only apply to
> > RGB and YUV input modes and
> > can be omitted for BT.656 input modes:
> > "
> >
> > This constraint is not implmented in the DT Schema.
> >
> > The original binding from the .txt file referenced
> > properties that is included in panel-timing.yaml.
> > These properties are kept here as we want as close to a 1:1
> > conversion as we can. If the properties should be dropped
> > from the binding then this is a follow-up patch.
> >
> > The properties in question are:
> > - pixelclk-active
> > - de-active
> > - hsync-active
> > - vsync-active
>
> Sorry about that. They should be dropped, but certainly it
> is fine to do with a follow up patch.
I changed my mind - lets try to avoid too many patches.
So if you do not mind I will do it in this patch - and note it in the
changelog.
Sam
>
> >
> > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> Yours,
> Linus Walleij
[Index of Archives]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|