On Sun, Mar 15, 2020 at 2:44 PM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > Independent bindings can be SPI slaves which for example is > the case for several panel bindings. > > Move SPI slave properties to spi-slave.yaml so the independent > SPI slave bindings can include spi-slave.yaml rather than > duplicating the properties. To me it seems like you are creating the common SPI slave bindings? Maybe the commit message should be about that. > + reg: > + minimum: 0 > + maximum: 256 255? Or am I wrong? Apart from that it looks good to me. Yours, Linus Walleij