Re: [PATCH] spi: spi-nxp-fspi: Fix a NULL vs IS_ERR() check in probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 12, 2020 at 09:11:44AM -0300, Fabio Estevam wrote:
> On Thu, Mar 12, 2020 at 8:33 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

> > The commit message for commit d166a73503ef ("spi: fspi: dynamically
> > alloc AHB memory") is not very good.  Why is it necessary to allocate
> > the AHB memory dynamically instead of during probe?  Also I suspect that

> Agreed and I made the same comment during review:
> https://patchwork.kernel.org/patch/11361581/

Indeed.  There had been an earlier discussion of what it was doing IIRC
but it didn't make it's way into the changelog.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux