By selecting MTD_SPI_NOR for SPI_HISI_SFC_V3XX, we may introduce unmet dependencies: WARNING: unmet direct dependencies detected for MTD_SPI_NOR Depends on [m]: MTD [=m] && SPI_MASTER [=y] Selected by [y]: - SPI_HISI_SFC_V3XX [=y] && SPI [=y] && SPI_MASTER [=y] && (ARM64 && ACPI [=y] || COMPILE_TEST [=y]) && HAS_IOMEM [=y] Since MTD_SPI_NOR is only selected by SPI_HISI_SFC_V3XX for practical reasons - slave devices use the spi-nor driver, enabled by MTD_SPI_NOR - just drop it. Signed-off-by: John Garry <john.garry@xxxxxxxxxx> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 66c6c0d77ea7..ad1a2547a414 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -299,7 +299,6 @@ config SPI_HISI_SFC_V3XX tristate "HiSilicon SPI-NOR Flash Controller for Hi16XX chipsets" depends on (ARM64 && ACPI) || COMPILE_TEST depends on HAS_IOMEM - select MTD_SPI_NOR help This enables support for HiSilicon v3xx SPI-NOR flash controller found in hi16xx chipsets. -- 2.17.1
[PATCH] spi: Stop selecting MTD_SPI_NOR for SPI_HISI_SFC_V3XX
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: [PATCH] spi: Stop selecting MTD_SPI_NOR for SPI_HISI_SFC_V3XX
- From: John Garry <john.garry@xxxxxxxxxx>
- Date: Thu, 12 Mar 2020 01:35:15 +0800
- Cc: <linux-spi@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-mtd@xxxxxxxxxxxxxxxxxxx>, <rdunlap@xxxxxxxxxxxxx>, <linux-next@xxxxxxxxxxxxxxx>, <joe@xxxxxxxxxxx>, <Tudor.Ambarus@xxxxxxxxxxxxx>, <sfr@xxxxxxxxxxxxxxxx>, <chenxiang66@xxxxxxxxxxxxx>, John Garry <john.garry@xxxxxxxxxx>
- Follow-Ups:
- Prev by Date: Re: [PATCH 0/6] Add interconnect support to UART, I2C, SPI and QSPI
- Next by Date: Applied "spi: Stop selecting MTD_SPI_NOR for SPI_HISI_SFC_V3XX" to the spi tree
- Previous by thread: [PATCH v7 00/13] add ecspi ERR009165 for i.mx6/7 soc family
- Next by thread: Applied "spi: Stop selecting MTD_SPI_NOR for SPI_HISI_SFC_V3XX" to the spi tree
- Index(es):
 |