Re: [PATCH] spi: Remove CONFIG_ prefix from Kconfig select

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2020-03-05 at 15:53 +0000, John Garry wrote:
> On 05/03/2020 15:15, Joe Perches wrote:
> > commit a2ca53b52e00 ("spi: Add HiSilicon v3xx SPI NOR flash
> > controller driver") likely inadvertently used a select statement
> > with a CONFIG_ prefix, remove the prefix.
> > 
> > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> 
> It's a pity checkpatch can't pick this stuff up...

You are free to write a rule and submit a patch.

The grammar is pretty hard to verify from a patch
fragment though.

There are 2 existing nominal false positives.

$ git grep 'select\b.*\bCONFIG_' -- '*/Kconfig*'
drivers/edac/Kconfig:     select CONFIG_ACPI_NFIT.
drivers/edac/Kconfig:     select CONFIG_ACPI_NFIT.





[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux