Re: [PATCH] spi: spi-fsl-espi: add GPIO chipselect support

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Maxim,

Thanks for your patch!

On Tue, Jan 28, 2020 at 8:26 AM Maxim Kochetkov <fido_max@xxxxxxxx> wrote:
> Subject: [PATCH] spi: spi-fsl-espi: add GPIO chipselect support
>
> eSPI controller can't send transactions without hardware chip selects.
> So, to use GPIO chip selects with eSPI controller we need to use one
> dedicated hardware chip select signal. To specify shared chip select for
> GPIO use "fsl,espi-shared-chipselect" DT property.

Do you need a property to specify this?
Can't the driver just pick an unused native chip select instead?
Recently I've added generic support for that to the SPI core, cfr. commit
7d93aecdb58d47e8 ("spi: Add generic support for unused native cs with
cs-gpios").

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds