Hi,
On 23/1/2020 5:58 PM, Vignesh Raghavendra wrote:
On 23/01/20 3:14 pm, Ramuthevar, Vadivel MuruganX wrote:
+};
+
+struct spi_mem_op_cadence {
+ const void *tx_buf;
+ void *rx_buf;
+ u32 len;
+ u32 tx_nbits:3;
+ u32 rx_nbits:3;
+};
+
Please drop thesee.. See further below for more info.
it's required for qspi-nand.
I don't see a need to mimic fields of spi_mem_op inside this driver. Why
not use them directly where needed?
Looking at the patch:
rx_nbits is never used.
tx_nbits is assigned value but never used
rx_buf is never used
tx_buf aliases to addrbuf which can be easily derived from op->addr.val
Yes, I have already derived, only placing the correct function to be
checked and added.
Regards
Vadivel
